Re: [Qemu-devel] [PATCH 2/2] machine_parse(): list supported machine types in their registration order

[Andreas Färber]

Am 22.09.2014 um 13:26 schrieb Laszlo Ersek:
> Based on the registration order captured in the previous patch, we sort
> the ad-hoc list printed for
> 
>   qemu-system-XXXX -M \?

Agree that the order is worth sanitizing. I would however argue that
registration order is not entirely stable either if you think of non-PC
cases where there's dozens of source files registering one machine each.
I would therefore propose alphabetical order as we do for QOM'ified CPUs.

> The GLib documentation is not overly clear if g_slist_sort() allocates a
> new list or reorders the input list in place, but:
> - it slightly suggests the latter,
> - and there is prior use in qemu that is consistent with the latter:
>   g_slist_sort() in qdev_print_devinfos() [qdev-monitor.c] sorts the
>   return value of object_class_get_list() the same as we do here in
>   machine_parse().

I believe I also assumed that for -cpu ? and/or QMP.

Regards,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg