Re: [Qemu-devel] [PATCH 06/30] test: usb: add port test to uhci unit test

[Igor Mammedov]

On Wed, 24 Sep 2014 14:30:25 +0200
Gerd Hoffmann <address@hidden> wrote:

> On Mi, 2014-09-24 at 11:47 +0000, Igor Mammedov wrote:
> > along with it move common code fro ehci test to
> > a separate file to avoid duplication.
> 
> Having the code mode as separate patch makes it easier to see the actual
> port test added ...
I'll do it on respin.

> 
> > +static void test_port_1(void)
> > +{
> > +    QPCIBus *pcibus;
> > +    struct qhc uhci;
> > +
> > +    pcibus = qpci_init_pc();
> > +    g_assert(pcibus != NULL);
> > +    usb_pci_init_one(pcibus, &uhci, QPCI_DEVFN(0x1d, 0), 4);
> > +    uhci_port_test(&uhci, 0, UHCI_PORT_CCS);
> >  }
> 
> ... here.  Why test only one of the two ports btw?
Because I'd like to simplify* following hotplug test
that uses port 2, no other ill intentions so far.

*(use the same qtest_start(...) for all test until)
> 
> cheers,
>   Gerd
> 
>