Re: [Qemu-devel] [PULL 3/3] s390x/css: catch ccw sequence errors

[Andreas Färber]

Am 26.09.2014 um 12:49 schrieb Christian Borntraeger:
> On 09/26/2014 12:36 PM, Andreas Färber wrote:
> 
>>> @@ -1414,6 +1423,7 @@ int subch_device_load(SubchDev *s, QEMUFile *f)
>>>          s->id.ciw[i].count = qemu_get_be16(f);
>>>      }
>>>      s->ccw_fmt_1 = qemu_get_byte(f);
>>> +    s->ccw_no_data_cnt = qemu_get_byte(f);
>>>      return 0;
>>>  }
>>>  
>>
>> You need to bump the version saved if you add fields (same as VMState),
>> and on load you need to check the version for whether to load the field
>> (or deny loading).
> 
> Alex brough up the same thing. As the cpu migration code is not yet upstream 
> (in prep right now) we concluded that this is still ok.
> 
> http://lists.gnu.org/archive/html/qemu-devel/2014-09/msg01094.html

You should justify that in each such commit message then.

However, the number space is large enough to bump the number each time
to avoid forgetting it later.

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg