[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 2/3] usb-hid: Add high speed mouse configurat
From: |
Jan Vesely |
Subject: |
Re: [Qemu-devel] [PATCH v4 2/3] usb-hid: Add high speed mouse configuration |
Date: |
Fri, 26 Sep 2014 10:43:13 -0400 |
On Fri, 2014-09-26 at 09:06 +0200, Gerd Hoffmann wrote:
> On Do, 2014-09-25 at 17:38 -0400, Jan Vesely wrote:
> > v2: add usb_mouse_properties
> > use macros for bmAttributes
> > v3: rebase
> > v4: rebase
>
> patch looks good, the only thing missing is the compat property, to make
> sure qemu machine types for 2.1 & older continue to have usb1 mouse+kbd
> by default.
>
> The property for the tablet is in hw/i386/pc_piix.c, have a look there
> how to do it. The compat properties for more recent machine types live
> in a header file (include/hw/i386/pc.h) so they can be shared between pc
> and q35.
I gave mouse and kbd the same treatment as tablet has in
hw/i386/pc_piix.c.
Speaking about properties do I need to add something for display and
head properties?
tablet adds both of them and they seem to be used together, however
keyboard only had display, and I added neither for mouse.
>
> Oh, and the patch history should not be in the commit message. You can
> add the history as notes (see 'git notes'). 'git format-patch' will use
> three dashes to separate the notes and 'git am' will strip them off so
> they appear on the list message but not in the commit log. Adding the
> tree dashes separator to the commit message will work too, at least as
> long as you don't send pull requests (in which case 'git am' would have
> no chance to strip off the notes).
OK I'll move these out of commit messages.
thanks,
jan
>
> cheers,
> Gerd
>
>
signature.asc
Description: This is a digitally signed message part