[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 10/17] accel: Move qtest accel registration t
|
From: |
Eduardo Habkost |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 10/17] accel: Move qtest accel registration to qtest.c |
|
Date: |
Fri, 26 Sep 2014 16:37:23 -0300 |
|
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Fri, Sep 26, 2014 at 05:06:43PM +0200, Paolo Bonzini wrote:
> Il 29/08/2014 22:31, Eduardo Habkost ha scritto:
> > As qtest_availble() returns 1 only when CONFIG_POSIX is set, keep
> > setting AccelClass.available to keep current behavior (this is different
> > from what we did for KVM and Xen).
>
> Hmm... as extra patches, could we only register the type on CONFIG_POSIX
> and thus get rid of available completely?
I am a bit confused about qtest support on Windows: is the "-qtest"
option supposed to be working (without accel=qtest) on !CONFIG_POSIX?
I see that you made qtest_init() not be a NOP anymore on !CONFIG_POSIX
on commit d4fce24f3a59eda081cdf2e38e7001591b95d173, but I don't know if
it makes sense to try to use it on Windows.
I was going to simply not compile accel.o at all on !CONFIG_POSIX, but I
don't know if it would break use cases that are expected to work.
--
Eduardo