Re: [Qemu-devel] [PATCH v3 4/7] qom: add description field in ObjectProperty struct

[Gonglei (Arei)]

Hi,

> Subject: Re: [PATCH v3 4/7] qom: add description field in ObjectProperty 
> struct
> 
> Il 27/09/2014 07:13, address@hidden ha scritto:
> > +void object_property_set_description(Object *obj, const char *name,
> > +                                     const char *description, Error
> **errp)
> > +{
> > +    ObjectProperty *op;
> > +
> > +    op = object_property_find(obj, name, errp);
> > +    if (!op) {
> > +        return;
> > +    }
> 
> The old description is leaked here if it is not NULL.
> 
Good catch.

> Since you are doing v4, please move the object_property_add_alias change
> here, too.
> 
OK. Thanks !

Best regards,
-Gonglei

> Paolo
> 
> > +    op->description = description ? g_strdup(description) : NULL;
> > +}
> > +