Re: [Qemu-devel] [PATCH v2 08/12] virtio-rng: fix virtio-rng child refcount in transports

[Cornelia Huck]

On Tue, 30 Sep 2014 14:10:34 +0800
<address@hidden> wrote:

> From: Gonglei <address@hidden>
> 
> object_initialize() leaves the object with a refcount of 1.
> object_property_add_child() adds its own reference which is dropped
> again when the property is deleted.
> 
> The upshot of this is that we always have a refcount >= 1.  Upon hot
> unplug the virtio-rng child is not finalized!
> 
> Drop our reference after the child property has been added to the
> parent.
> 
> Signed-off-by: Gonglei <address@hidden>
> ---
>  hw/s390x/s390-virtio-bus.c | 1 +
>  hw/s390x/virtio-ccw.c      | 1 +
>  hw/virtio/virtio-pci.c     | 1 +
>  3 files changed, 3 insertions(+)

Reviewed-by: Cornelia Huck <address@hidden>