[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered |
Date: |
Wed, 22 Oct 2014 17:26:50 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
Alex Bennée <address@hidden> writes:
> Markus Armbruster <address@hidden> writes:
>
>> In my experience, too many files are not covered by MAINTAINERS.
>> scripts/get_maintainer.pl falls back to git then, unless you say
>> --no-git-fallback. Copies sent there tends to annoy their recipients
>> without accomplishing all that much.
>>
>> Two obvious improvements:
>>
>> * Easy: Flip scripts/get_maintainer.pl's default to --no-git-fallback.
>> I'll post the obvious patch, please raise your objections there.
>
> As it happens I do that in my .git/config, but...
>
>> * Harder: improve MAINTAINERS coverage.
>
> Well one problem is no MAINTAINER == no obvious tree to take you
> patches. This is my main bugbear. I have a few patch series that touch a
> smattering of files (e.g. logging improvements) that don't fall under
> one particular sub-system but are probably a little too broad for the
> trivial tree.
I've been there quite a few times. No easy answers.
>> Where are the unmaintained files? Top-scoring directories outside
>> tests/ and include/, files in subdirs not counted:
>>
>> #files directory
>> 84 68% .
>
> I suspect there is a bunch of general infrastructure bits that has this
> sort of property. Maybe some effort be made to move related bits into
> sub-directories (with MAINTAINERS) where they are less likely to fall
> in-between the cracks?
No objection to moving stuff to more appropriate homes. But it's not
necessary for MAINTAINERS coverage. Just add the necessary F: lines.
> <snip>
>
>> Ideas? Takers?
>
> My 0.2c ;-)
Thanks!
- Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered, (continued)
- Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered, Alexander Graf, 2014/10/22
- Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered, Paolo Bonzini, 2014/10/22
- [Qemu-devel] MAINTAINERS: please add myself as usb-serial.c and baum.c maintainer, Samuel Thibault, 2014/10/22
- Re: [Qemu-devel] MAINTAINERS: please add myself as usb-serial.c and baum.c maintainer, Paolo Bonzini, 2014/10/22
- Re: [Qemu-devel] MAINTAINERS: please add myself as usb-serial.c and baum.c maintainer, Markus Armbruster, 2014/10/22
- Re: [Qemu-devel] MAINTAINERS: please add myself as usb-serial.c and baum.c maintainer, Samuel Thibault, 2014/10/22
- Re: [Qemu-devel] MAINTAINERS: please add myself as usb-serial.c and baum.c maintainer, Markus Armbruster, 2014/10/22
- Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered, Michael Roth, 2014/10/22
- Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered, Luiz Capitulino, 2014/10/22
Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered, Alex Bennée, 2014/10/22
- Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered,
Markus Armbruster <=