Re: [Qemu-devel] [PATCH v4] error: passing a negative value to an os_errno is wrong

[Max Reitz]

On 2014-11-12 at 08:08, SeokYeon Hwang wrote:
> Added 'assert(os_errno >= 0)' in 'error_set_errno()'.
>
> Signed-off-by: SeokYeon Hwang <address@hidden>
> ---
>   util/error.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/util/error.c b/util/error.c
> index 2ace0d8..6c9d995 100644
> --- a/util/error.c
> +++ b/util/error.c
> @@ -62,6 +62,7 @@ void error_set_errno(Error **errp, int os_errno, ErrorClass 
> err_class,
>           return;
>       }
>       assert(*errp == NULL);
> +    assert(os_errno >= 0);
>   
>       err = g_malloc0(sizeof(*err));
>   

Reviewed-by: Max Reitz <address@hidden>