Re: [Qemu-devel] [PATCH v8 08/10] qapi: Add transaction support to block-dirty-bitmap-{add, enable, disable}

[Max Reitz]

On 2014-11-26 at 18:41, John Snow wrote:
> From: Fam Zheng <address@hidden>
>
> This adds three qmp commands to transactions.
>
> Users can stop a dirty bitmap, start backup of it, and start another
> dirty bitmap atomically, so that the dirty bitmap is tracked
> incrementally and we don't miss any write.
>
> Signed-off-by: Fam Zheng <address@hidden>
> Signed-off-by: John Snow <address@hidden>
> ---
>   blockdev.c       | 85 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>   qapi-schema.json |  5 +++-
>   2 files changed, 89 insertions(+), 1 deletion(-)

[snip]

> diff --git a/blockdev.c b/blockdev.c
> index 1a56959..275eb43 100644
> --- a/blockdev.c
> +++ b/blockdev.c
> @@ -1564,6 +1634,21 @@ static const BdrvActionOps actions[] = {
>           .prepare  = internal_snapshot_prepare,
>           .abort = internal_snapshot_abort,
>       },

I probably missed that in my review for v7 because I based that on 
my/Kevin's block-next branch instead of Stefan's (which I'm doing now): 
This conflicts with Stefan's AioContext series. Now there's a .clean, so 
it should read:

         .abort = internal_snapshot_abort,
         .clean = internal_snapshot_clean,
     },

(Hopefully nbsps will keep Thunderbird from breaking the indentation...)

With that fixed:

Reviewed-by: Max Reitz <address@hidden>