[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH 1/3] qemu-img bench
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [RFC PATCH 1/3] qemu-img bench |
Date: |
Mon, 1 Dec 2014 11:15:46 +0000 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Fri, Nov 28, 2014 at 01:19:59PM +0100, Kevin Wolf wrote:
> Am 28.11.2014 um 12:49 hat Stefan Hajnoczi geschrieben:
> > On Wed, Nov 26, 2014 at 03:46:42PM +0100, Kevin Wolf wrote:
> > > + while (data.n > 0) {
> > > + main_loop_wait(false);
> > > + }
> >
> > Why is this false (non-blocking)? This is why you get the main loop
> > spun warning message.
> >
> > Using true (blocking) seems like the right thing. data.n changes as
> > part of the callback, which is invoked from the main loop. There is no
> > need to be non-blocking.
>
> I think the parameter has exactly the opposite meaning as what you
> describe:
>
> int main_loop_wait(int nonblocking)
>
> If it were true, you would get timeout = 0. qemu-io and qemu-nbd also
> pass false here.
Oops, you are right! Sorry, I was confused.
Stefan
pgp2NNwFWbCxp.pgp
Description: PGP signature
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [RFC PATCH 1/3] qemu-img bench,
Stefan Hajnoczi <=