[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 2/6] vmdk: Fix comment to match code of exten
From: |
Don Koch |
Subject: |
Re: [Qemu-devel] [PATCH v4 2/6] vmdk: Fix comment to match code of extent lines |
Date: |
Thu, 4 Dec 2014 09:18:07 -0500 |
On Thu, 4 Dec 2014 07:28:30 +0800
Fam Zheng <address@hidden> wrote:
> commit 04d542c8b (vmdk: support vmfs files) added support of VMFS extent
> type but the comment above the changed code is left out. Update the
> comment so they are consistent.
>
> Signed-off-by: Fam Zheng <address@hidden>
> ---
Reviewed-by: Don Koch <address@hidden>
> block/vmdk.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/block/vmdk.c b/block/vmdk.c
> index ebb4b70..4ee0aed 100644
> --- a/block/vmdk.c
> +++ b/block/vmdk.c
> @@ -785,10 +785,12 @@ static int vmdk_parse_extents(const char *desc,
> BlockDriverState *bs,
> VmdkExtent *extent;
>
> while (*p) {
> - /* parse extent line:
> + /* parse extent line in one of below formats:
> + *
> * RW [size in sectors] FLAT "file-name.vmdk" OFFSET
> - * or
> * RW [size in sectors] SPARSE "file-name.vmdk"
> + * RW [size in sectors] VMFS "file-name.vmdk"
> + * RW [size in sectors] VMFSSPARSE "file-name.vmdk"
> */
> flat_offset = -1;
> ret = sscanf(p, "%10s %" SCNd64 " %10s \"%511[^\n\r\"]\" %" SCNd64,
> --
> 1.9.3
>
- [Qemu-devel] [PATCH v4 0/6] vmdk: A few small fixes, Fam Zheng, 2014/12/03
- [Qemu-devel] [PATCH v4 1/6] vmdk: Use g_random_int to generate CID, Fam Zheng, 2014/12/03
- [Qemu-devel] [PATCH v4 3/6] vmdk: Clean up descriptor file reading, Fam Zheng, 2014/12/03
- [Qemu-devel] [PATCH v4 2/6] vmdk: Fix comment to match code of extent lines, Fam Zheng, 2014/12/03
- [Qemu-devel] [PATCH v4 5/6] vmdk: Remove unnecessary initialization, Fam Zheng, 2014/12/03
- [Qemu-devel] [PATCH v4 6/6] vmdk: Set errp on failures in vmdk_open_vmdk4, Fam Zheng, 2014/12/03
- [Qemu-devel] [PATCH v4 4/6] vmdk: Check descriptor file length when reading it, Fam Zheng, 2014/12/03
- Re: [Qemu-devel] [PATCH v4 0/6] vmdk: A few small fixes, Max Reitz, 2014/12/04