[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] s390/pci: remove unnecessary cpu_synchronize_st
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [PATCH] s390/pci: remove unnecessary cpu_synchronize_state |
Date: |
Mon, 8 Dec 2014 12:48:39 +0100 |
On Mon, 8 Dec 2014 09:18:59 +0100
Frank Blaschka <address@hidden> wrote:
> Remove all unnecessary calls to cpu_synchronize_state
>
> Signed-off-by: Frank Blaschka <address@hidden>
> ---
> hw/s390x/s390-pci-inst.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/hw/s390x/s390-pci-inst.c b/hw/s390x/s390-pci-inst.c
> index f503665..83ab60f 100644
> --- a/hw/s390x/s390-pci-inst.c
> +++ b/hw/s390x/s390-pci-inst.c
> @@ -564,8 +564,6 @@ int pcistb_service_call(S390CPU *cpu, uint8_t r1, uint8_t
> r3, uint64_t gaddr)
> uint8_t pcias;
> uint8_t len;
>
> - cpu_synchronize_state(CPU(cpu));
> -
> if (env->psw.mask & PSW_MASK_PSTATE) {
> program_interrupt(env, PGM_PRIVILEGED, 6);
> return 0;
> @@ -711,8 +709,6 @@ int mpcifc_service_call(S390CPU *cpu, uint8_t r1,
> uint64_t fiba)
> S390PCIBusDevice *pbdev;
> uint64_t cc = ZPCI_PCI_LS_OK;
>
> - cpu_synchronize_state(CPU(cpu));
> -
> if (env->psw.mask & PSW_MASK_PSTATE) {
> program_interrupt(env, PGM_PRIVILEGED, 6);
> return 0;
> @@ -786,8 +782,6 @@ int stpcifc_service_call(S390CPU *cpu, uint8_t r1,
> uint64_t fiba)
> uint32_t data;
> uint64_t cc = ZPCI_PCI_LS_OK;
>
> - cpu_synchronize_state(CPU(cpu));
> -
> if (env->psw.mask & PSW_MASK_PSTATE) {
> program_interrupt(env, PGM_PRIVILEGED, 6);
> return 0;
Reviewed-by: Thomas Huth <address@hidden>