[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/9] pc: acpi: fix WindowsXP BSOD when memory ho
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH 1/9] pc: acpi: fix WindowsXP BSOD when memory hotplug is enabled |
Date: |
Mon, 8 Dec 2014 22:57:05 +0200 |
On Mon, Dec 08, 2014 at 04:08:00PM +0000, Igor Mammedov wrote:
> ACPI parser in XP considers PNP0A06 devices of CPU and
> memory hotplug as duplicates. Adding unique _UID
> to CPU hotplug device fixes BSOD.
>
> Signed-off-by: Igor Mammedov <address@hidden>
And let's add them for memory hotplug as well?
Also, if we do stable branch release, we probably
want to only do it for memory hotplug in a separate
patch, right?
This way users who don't enable memory hotplug
are unaffected, reduces risk slightly.
> ---
> hw/i386/acpi-dsdt-cpu-hotplug.dsl | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/i386/acpi-dsdt-cpu-hotplug.dsl
> b/hw/i386/acpi-dsdt-cpu-hotplug.dsl
> index 34aab5a..268d870 100644
> --- a/hw/i386/acpi-dsdt-cpu-hotplug.dsl
> +++ b/hw/i386/acpi-dsdt-cpu-hotplug.dsl
> @@ -94,6 +94,7 @@ Scope(\_SB) {
>
> Device(CPU_HOTPLUG_RESOURCE_DEVICE) {
> Name(_HID, EisaId("PNP0A06"))
> + Name(_UID, "CPU hotplug resources")
>
> Name(_CRS, ResourceTemplate() {
> IO(Decode16, CPU_STATUS_BASE, CPU_STATUS_BASE, 0, CPU_STATUS_LEN)
> --
> 1.8.3.1
- Re: [Qemu-devel] [PATCH 4/9] acpi: build_append_nameseg(): add padding if necessary, (continued)
[Qemu-devel] [PATCH 3/9] pc: acpi-build: cleanup AcpiPmInfo initialization, Igor Mammedov, 2014/12/08
[Qemu-devel] [PATCH 5/9] acpi: move generic aml building helpers into dedictated file, Igor Mammedov, 2014/12/08
[Qemu-devel] [PATCH 1/9] pc: acpi: fix WindowsXP BSOD when memory hotplug is enabled, Igor Mammedov, 2014/12/08
- Re: [Qemu-devel] [PATCH 1/9] pc: acpi: fix WindowsXP BSOD when memory hotplug is enabled,
Michael S. Tsirkin <=
[Qemu-devel] [PATCH 8/9] acpi: drop min-bytes in build_package(), Igor Mammedov, 2014/12/08
[Qemu-devel] [PATCH 9/9] pc: acpi-build: replace recursive PCI bus tree generation with loop based, Igor Mammedov, 2014/12/08
[Qemu-devel] [PATCH 7/9] acpi: replace opencoded notify codes with named values, Igor Mammedov, 2014/12/08