[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.3 0/2] block: Fix for trailing whitespace
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [PATCH for-2.3 0/2] block: Fix for trailing whitespace in qemu-img create and its tests |
Date: |
Thu, 11 Dec 2014 08:21:07 +0800 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Wed, 12/10 13:50, Markus Armbruster wrote:
> Fam Zheng <address@hidden> writes:
>
> > This will make it easier to keep checkpatch.pl happy.
> >
> > Fam Zheng (2):
> > qemu-iotests: Remove traling whitespaces in *.out
> > block: Don't add trailing space in "Formating..." message
>
> Sounds like PATCH 1 breaks the test, and PATCH 2 unbreaks it. If that's
> the case, they need to be squashed.
No. Our qemu-iotests driver ignores ending space:
if diff -w "$reference" $tmp.out >/dev/null 2>&1
then
echo ""
if $err
then
:
else
echo "$seq `expr $stop - $start`" >>$tmp.time
fi
else
echo " - output mismatch (see $seq.out.bad)"
mv $tmp.out $seq.out.bad
$diff -w "$reference" $seq.out.bad
err=true
fi
Are you happy with the "sep" or do you want a full-fledged version?
Fam
- [Qemu-devel] [PATCH for-2.3 0/2] block: Fix for trailing whitespace in qemu-img create and its tests, Fam Zheng, 2014/12/09
- [Qemu-devel] [PATCH for-2.3 2/2] block: Don't add trailing space in "Formating..." message, Fam Zheng, 2014/12/09
- [Qemu-devel] [PATCH for-2.3 1/2] qemu-iotests: Remove traling whitespaces in *.out, Fam Zheng, 2014/12/09
- Re: [Qemu-devel] [PATCH for-2.3 0/2] block: Fix for trailing whitespace in qemu-img create and its tests, Eric Blake, 2014/12/09
- Re: [Qemu-devel] [PATCH for-2.3 0/2] block: Fix for trailing whitespace in qemu-img create and its tests, Markus Armbruster, 2014/12/10
- Re: [Qemu-devel] [PATCH for-2.3 0/2] block: Fix for trailing whitespace in qemu-img create and its tests,
Fam Zheng <=
- Re: [Qemu-devel] [PATCH for-2.3 0/2] block: Fix for trailing whitespace in qemu-img create and its tests, Stefan Hajnoczi, 2014/12/12