Re: [Qemu-devel] [PATCH v2 0/4] target-tricore: fixes to opcode encoding and register dump

[Bastian Koppelmann]

On 12/12/2014 02:10 PM, Alex Zuepke wrote:
> Hi Bastian,
>
> my previous patches again, I hope they are well-formed now:
> 1. fix the offset masking in BOL format
> 2. fix a typo in BOL format
> 3. add the missing 64-bit "MOV Ex, simm16" variant in RLC format
> 4. pretty-print register dump
>
> Best regards
> Alex
>
>
> Alex Zuepke (4):
>    target-tricore: fix offset masking in BOL format
>    target-tricore: typo in BOL format
>    target-tricore: add missing 64-bit MOV in RLC format
>    target-tricore: pretty-print register dump and show more status
>      registers
>
>   target-tricore/translate.c       |   32 +++++++++++++++++++++++++-------
>   target-tricore/tricore-opcodes.h |    5 +++--
>   2 files changed, 28 insertions(+), 9 deletions(-)

Hi Alex,

the patches look much better now. However be careful with your vX's. You 
only added a v2 to your coverletter, so my email client cannot group 
them correctly.

An easy way to do that is e.g.:

git format-patch -4 --cover-letter --subject-prefix="PATCH v3"

Cheers,
Bastian