|
From: | Vladimir Sementsov-Ogievskiy |
Subject: | Re: [Qemu-devel] [PATCH 8/9] migration: add dirty parameter |
Date: | Mon, 15 Dec 2014 11:33:01 +0300 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 |
Thanks. It's interesting that checkpatch.pl doesn't warn about this line. Best regards, Vladimir On 11.12.2014 18:18, Eric Blake wrote:
On 12/11/2014 07:17 AM, Vladimir Sementsov-Ogievskiy wrote:Add dirty parameter to qmp-migrate command. If this parameter is true, block-migration.c will migrate dirty bitmaps. This parameter can be used without "blk" parameter to migrate only dirty bitmaps, skipping block migration. Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden> --- +++ b/qapi-schema.json @@ -1660,7 +1660,7 @@ # Since: 0.14.0 ## { 'command': 'migrate', - 'data': {'uri': 'str', '*blk': 'bool', '*inc': 'bool', '*detach': 'bool' } } + 'data': {'uri': 'str', '*blk': 'bool', '*inc': 'bool', '*dirty': 'bool', '*detach': 'bool' } }Missing documentation of the new option (including a mention of '(since 2.3)'. Also, please keep lines shorter than 80 columns.
[Prev in Thread] | Current Thread | [Next in Thread] |