[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 5/5] bootdevice: add Error **errp argument for QE
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PULL 5/5] bootdevice: add Error **errp argument for QEMUBootSetHandler |
Date: |
Tue, 16 Dec 2014 12:42:48 +0000 |
On 16 December 2014 at 09:22, <address@hidden> wrote:
> @@ -412,9 +411,7 @@ void pc_cmos_init(ram_addr_t ram_size, ram_addr_t
> above_4g_mem_size,
> object_property_set_link(OBJECT(machine), OBJECT(s),
> "rtc_state", &error_abort);
>
> - if (set_boot_dev(s, boot_device)) {
> - exit(1);
> - }
> + set_boot_dev(s, boot_device, &error_abort);
This turns a "print error message and exit" path into
an abort(), which doesn't seem right (this can be triggered
by bad user input arguments, yes?). error_abort should
only be used in cases where you would assert() if there
was an error (ie where it would be a QEMU bug if it
happened).
thanks
-- PMM
[Qemu-devel] [PULL 3/5] bootdevice: add Error **errp argument for qemu_boot_set(), arei . gonglei, 2014/12/16
[Qemu-devel] [PULL 1/5] bootdevice: move code about bootorder from vl.c to bootdevice.c, arei . gonglei, 2014/12/16
[Qemu-devel] [PULL 4/5] bootdevice: add validate check for qemu_boot_set(), arei . gonglei, 2014/12/16
[Qemu-devel] [PULL 2/5] bootdevice: add Error **errp argument for validate_bootdevices(), arei . gonglei, 2014/12/16
Re: [Qemu-devel] [PULL 0/5] bootdevice patches, Peter Maydell, 2014/12/16