[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH 2/2] qga: implement qmp_guest_get_os_version
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [RFC PATCH 2/2] qga: implement qmp_guest_get_os_version for windows |
Date: |
Tue, 16 Dec 2014 09:26:38 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 |
On 12/16/2014 04:48 AM, Yan Vugenfirer wrote:
>> +
>> + if (si.wProcessorArchitecture == PROCESSOR_ARCHITECTURE_AMD64 ||
>> + si.wProcessorArchitecture == PROCESSOR_ARCHITECTURE_IA64) {
>
> If one of the motivations is to update drivers on the guest - those should be
> treated as deferent architectures.
> Why not return string as well (x64, x86, IA64, ARM)?
The architecture should already be known by the host (after all, the
flavor of qemu running the guest should tell you what architecture the
guest would report).
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature