[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V2 3/8] pc: acpi-build: cleanup AcpiPmInfo initi
From: |
Claudio Fontana |
Subject: |
Re: [Qemu-devel] [PATCH V2 3/8] pc: acpi-build: cleanup AcpiPmInfo initialization |
Date: |
Fri, 19 Dec 2014 10:25:18 +0100 |
User-agent: |
Mozilla/5.0 (Windows NT 6.1; rv:24.0) Gecko/20100101 Thunderbird/24.0.1 |
On 16.12.2014 11:58, Igor Mammedov wrote:
> zero initialize AcpiPmInfo struct to reduce code bloat
> a little bit.
>
> Signed-off-by: Igor Mammedov <address@hidden>
> ---
> hw/i386/acpi-build.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
> index 1fb92e5..f5ec66a 100644
> --- a/hw/i386/acpi-build.c
> +++ b/hw/i386/acpi-build.c
> @@ -161,6 +161,8 @@ static void acpi_get_pm_info(AcpiPmInfo *pm)
> Object *obj = NULL;
> QObject *o;
>
> + memset(pm, 0, sizeof(*pm));
> +
> if (piix) {
> obj = piix;
> }
> @@ -173,22 +175,16 @@ static void acpi_get_pm_info(AcpiPmInfo *pm)
> o = object_property_get_qobject(obj, ACPI_PM_PROP_S3_DISABLED, NULL);
> if (o) {
> pm->s3_disabled = qint_get_int(qobject_to_qint(o));
> - } else {
> - pm->s3_disabled = false;
> }
> qobject_decref(o);
> o = object_property_get_qobject(obj, ACPI_PM_PROP_S4_DISABLED, NULL);
> if (o) {
> pm->s4_disabled = qint_get_int(qobject_to_qint(o));
> - } else {
> - pm->s4_disabled = false;
> }
> qobject_decref(o);
> o = object_property_get_qobject(obj, ACPI_PM_PROP_S4_VAL, NULL);
> if (o) {
> pm->s4_val = qint_get_int(qobject_to_qint(o));
> - } else {
> - pm->s4_val = false;
> }
> qobject_decref(o);
>
>
Reviewed-by: Claudio Fontana <address@hidden>
--
Claudio Fontana
Server Virtualization Architect
Huawei Technologies Duesseldorf GmbH
Riesstraße 25 - 80992 München
office: +49 89 158834 4135
mobile: +49 15253060158
- [Qemu-devel] [PATCH V2 0/8] pc: acpi: various fixes and cleanups, Igor Mammedov, 2014/12/16
- [Qemu-devel] [PATCH V2 1/8] pc: acpi: fix WindowsXP BSOD when memory hotplug is enabled, Igor Mammedov, 2014/12/16
- [Qemu-devel] [PATCH V2 2/8] pc: acpi: decribe bridge device as not hotpluggable, Igor Mammedov, 2014/12/16
- [Qemu-devel] [PATCH V2 3/8] pc: acpi-build: cleanup AcpiPmInfo initialization, Igor Mammedov, 2014/12/16
- Re: [Qemu-devel] [PATCH V2 3/8] pc: acpi-build: cleanup AcpiPmInfo initialization,
Claudio Fontana <=
- [Qemu-devel] [PATCH V2 4/8] acpi: build_append_nameseg(): add padding if necessary, Igor Mammedov, 2014/12/16
- [Qemu-devel] [PATCH V2 5/8] acpi: move generic aml building helpers into dedictated file, Igor Mammedov, 2014/12/16
- [Qemu-devel] [PATCH V2 7/8] acpi: drop min-bytes in build_package(), Igor Mammedov, 2014/12/16
- [Qemu-devel] [PATCH V2 6/8] acpi: add build_append_namestring() helper, Igor Mammedov, 2014/12/16
- [Qemu-devel] [PATCH V2 8/8] pc: acpi-build: simplify PCI bus tree generation, Igor Mammedov, 2014/12/16