[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 3/8] pc: acpi-build: cleanup AcpiPmInfo initializ
From: |
Igor Mammedov |
Subject: |
[Qemu-devel] [PATCH v3 3/8] pc: acpi-build: cleanup AcpiPmInfo initialization |
Date: |
Fri, 19 Dec 2014 11:46:59 +0000 |
zero initialize AcpiPmInfo struct to reduce code bloat
a little bit.
Signed-off-by: Igor Mammedov <address@hidden>
Reviewed-by: Claudio Fontana <address@hidden>
---
hw/i386/acpi-build.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
index c151fde..0351363 100644
--- a/hw/i386/acpi-build.c
+++ b/hw/i386/acpi-build.c
@@ -169,6 +169,8 @@ static void acpi_get_pm_info(AcpiPmInfo *pm)
Object *obj = NULL;
QObject *o;
+ memset(pm, 0, sizeof(*pm));
+
if (piix) {
obj = piix;
}
@@ -181,22 +183,16 @@ static void acpi_get_pm_info(AcpiPmInfo *pm)
o = object_property_get_qobject(obj, ACPI_PM_PROP_S3_DISABLED, NULL);
if (o) {
pm->s3_disabled = qint_get_int(qobject_to_qint(o));
- } else {
- pm->s3_disabled = false;
}
qobject_decref(o);
o = object_property_get_qobject(obj, ACPI_PM_PROP_S4_DISABLED, NULL);
if (o) {
pm->s4_disabled = qint_get_int(qobject_to_qint(o));
- } else {
- pm->s4_disabled = false;
}
qobject_decref(o);
o = object_property_get_qobject(obj, ACPI_PM_PROP_S4_VAL, NULL);
if (o) {
pm->s4_val = qint_get_int(qobject_to_qint(o));
- } else {
- pm->s4_val = false;
}
qobject_decref(o);
--
1.8.3.1
- [Qemu-devel] [PATCH v3 0/8] pc: acpi: various fixes and cleanups, Igor Mammedov, 2014/12/19
- [Qemu-devel] [PATCH v3 2/8] pc: acpi: decribe bridge device as not hotpluggable, Igor Mammedov, 2014/12/19
- [Qemu-devel] [PATCH v3 4/8] acpi: build_append_nameseg(): add padding if necessary, Igor Mammedov, 2014/12/19
- [Qemu-devel] [PATCH v3 3/8] pc: acpi-build: cleanup AcpiPmInfo initialization,
Igor Mammedov <=
- [Qemu-devel] [PATCH v3 1/8] pc: acpi: fix WindowsXP BSOD when memory hotplug is enabled, Igor Mammedov, 2014/12/19
- [Qemu-devel] [PATCH v3 5/8] acpi: move generic aml building helpers into dedictated file, Igor Mammedov, 2014/12/19
- [Qemu-devel] [PATCH v3 8/8] pc: acpi-build: simplify PCI bus tree generation, Igor Mammedov, 2014/12/19
- [Qemu-devel] [PATCH v3 7/8] acpi: drop min-bytes in build_package(), Igor Mammedov, 2014/12/19
- [Qemu-devel] [PATCH v3 6/8] acpi: add build_append_namestring() helper, Igor Mammedov, 2014/12/19