[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCHv2 0/8] pseries: Fix and extend PAPR RTC implemen
From: |
Alexander Graf |
Subject: |
Re: [Qemu-devel] [PATCHv2 0/8] pseries: Fix and extend PAPR RTC implementation |
Date: |
Tue, 23 Dec 2014 01:31:43 +0100 |
User-agent: |
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 |
On 23.12.14 01:16, David Gibson wrote:
> At the moment, the PAPR RTC implementation (actually a paravirt
> firmware interface, rather than a normal device) works directly off
> host time, and so doesn't respect the options such as clock=vm which
> can be specified in the -rtc command line option.
>
> Extending the PAPR RTC in this way makes it clearer it should probably
> be its own separate qdev, so this series also implements that.
>
> Finally it moves the code from mc146818rtc for publishing the RTC time
> via QOM into generic QOM helpers, and extends the PAPR RTC driver to
> export in a similar way.
>
> I've done some basic sanity testing on this, but not much. In
> particular I haven't tested the migration code much yet, so that might
> need revision still.
I think we're on the right track. After this patch set, I would like to
see no exported functions related to RTC in include/hw/ppc/spapr.h left
though :). I'm fairly sure you can get all of them handled via qom
properties instead.
Alex
- Re: [Qemu-devel] [PATCHv2 7/8] pseries: Move rtc_offset into RTC device's state structure, (continued)
[Qemu-devel] [PATCHv2 3/8] pseries: Add spapr_rtc_read() helper function, David Gibson, 2014/12/22
[Qemu-devel] [PATCHv2 2/8] pseries: Add more parameter validation in RTAS time of day functions, David Gibson, 2014/12/22
[Qemu-devel] [PATCHv2 4/8] Generalize QOM publishing of date and time from mc146818rtc.c, David Gibson, 2014/12/22
[Qemu-devel] [PATCHv2 6/8] pseries: Make the PAPR RTC a qdev device, David Gibson, 2014/12/22
[Qemu-devel] [PATCHv2 8/8] pseries: Export RTC time via QOM, David Gibson, 2014/12/22
Re: [Qemu-devel] [PATCHv2 0/8] pseries: Fix and extend PAPR RTC implementation,
Alexander Graf <=