[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v4 07/16] qemu-img: Use blk_new_open() in img_open()
From: |
Max Reitz |
Subject: |
[Qemu-devel] [PATCH v4 07/16] qemu-img: Use blk_new_open() in img_open() |
Date: |
Thu, 5 Feb 2015 13:58:16 -0500 |
Signed-off-by: Max Reitz <address@hidden>
---
qemu-img.c | 20 ++++++--------------
1 file changed, 6 insertions(+), 14 deletions(-)
diff --git a/qemu-img.c b/qemu-img.c
index 7154055..a67688d 100644
--- a/qemu-img.c
+++ b/qemu-img.c
@@ -293,32 +293,24 @@ static BlockBackend *img_open(const char *id, const char
*filename,
{
BlockBackend *blk;
BlockDriverState *bs;
- BlockDriver *drv;
char password[256];
Error *local_err = NULL;
- int ret;
-
- blk = blk_new_with_bs(id, &error_abort);
- bs = blk_bs(blk);
+ QDict *options = NULL;
if (fmt) {
- drv = bdrv_find_format(fmt);
- if (!drv) {
- error_report("Unknown file format '%s'", fmt);
- goto fail;
- }
- } else {
- drv = NULL;
+ options = qdict_new();
+ qdict_put(options, "driver", qstring_from_str(fmt));
}
- ret = bdrv_open(&bs, filename, NULL, NULL, flags, drv, &local_err);
- if (ret < 0) {
+ blk = blk_new_open(id, filename, NULL, options, flags, &local_err);
+ if (!blk) {
error_report("Could not open '%s': %s", filename,
error_get_pretty(local_err));
error_free(local_err);
goto fail;
}
+ bs = blk_bs(blk);
if (bdrv_is_encrypted(bs) && require_io) {
qprintf(quiet, "Disk image '%s' is encrypted.\n", filename);
if (read_password(password, sizeof(password)) < 0) {
--
2.1.0
- Re: [Qemu-devel] [PATCH v4 04/16] iotests: Add test for driver=qcow2, format=qcow2, (continued)
- [Qemu-devel] [PATCH v4 01/16] block: Lift some BDS functions to the BlockBackend, Max Reitz, 2015/02/05
- [Qemu-devel] [PATCH v4 05/16] blockdev: Use blk_new_open() in blockdev_init(), Max Reitz, 2015/02/05
- [Qemu-devel] [PATCH v4 03/16] block: Add Error parameter to bdrv_find_protocol(), Max Reitz, 2015/02/05
- [Qemu-devel] [PATCH v4 07/16] qemu-img: Use blk_new_open() in img_open(),
Max Reitz <=
- [Qemu-devel] [PATCH v4 06/16] block/xen: Use blk_new_open() in blk_connect(), Max Reitz, 2015/02/05
- [Qemu-devel] [PATCH v4 08/16] qemu-img: Use blk_new_open() in img_rebase(), Max Reitz, 2015/02/05
- [Qemu-devel] [PATCH v4 12/16] qemu-io: Remove "growable" option, Max Reitz, 2015/02/05