[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 2/4] coverity: Model GLib string allocation parti
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PULL 2/4] coverity: Model GLib string allocation partially |
Date: |
Wed, 11 Feb 2015 19:41:03 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 |
On 05/02/2015 17:24, Markus Armbruster wrote:
> +
> +char *g_strdup(const char *s)
> +{
> + char *dup;
> + size_t i;
> +
> + if (!s) {
> + return NULL;
> + }
> +
> + __coverity_string_null_sink__(s);
> + __coverity_string_size_sink__(s);
What's __coverity_string_size_sink__? It is likely responsible for this
in libcacard:
Unbounded source buffer (STRING_SIZE)
string_size: Passing string argv[argc - 2] of unknown size to g_strdup,
which expects a string of a particular size
I guess it's okay to mark this as intentional?
>
> +char *g_strndup(const char *s, size_t n)
> +{
> + char *dup;
> + size_t i;
> +
> + __coverity_negative_sink__(n);
> +
> + if (!s) {
> + return NULL;
> + }
> +
> + dup = g_malloc(n + 1);
This should be g_malloc0 I think.
Paolo
- [Qemu-devel] [PULL 0/4] coverity: Improve and extend model, Markus Armbruster, 2015/02/05
- [Qemu-devel] [PULL 4/4] MAINTAINERS: Add myself as Coverity model maintainer, Markus Armbruster, 2015/02/05
- [Qemu-devel] [PULL 1/4] coverity: Improve model for GLib memory allocation, Markus Armbruster, 2015/02/05
- [Qemu-devel] [PULL 3/4] coverity: Model g_free() isn't necessarily free(), Markus Armbruster, 2015/02/05
- [Qemu-devel] [PULL 2/4] coverity: Model GLib string allocation partially, Markus Armbruster, 2015/02/05
- Re: [Qemu-devel] [PULL 2/4] coverity: Model GLib string allocation partially,
Paolo Bonzini <=
- Re: [Qemu-devel] [PULL 0/4] coverity: Improve and extend model, Peter Maydell, 2015/02/05