[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 06/52] pc: acpi-build: use aml_def_block() fo
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH v3 06/52] pc: acpi-build: use aml_def_block() for declaring SSDT table |
Date: |
Wed, 18 Feb 2015 12:39:44 +0100 |
On Wed, Feb 18, 2015 at 10:57:18AM +0100, Igor Mammedov wrote:
> On Tue, 17 Feb 2015 17:42:00 +0100
> "Michael S. Tsirkin" <address@hidden> wrote:
>
> > On Mon, Feb 09, 2015 at 10:53:28AM +0000, Igor Mammedov wrote:
> > > it replaces prebuilt SSDT table header template copying/patching
> > > with AML API
> > >
> > > Signed-off-by: Igor Mammedov <address@hidden>
> >
> > I note that this changed the SSDT signature in random ways,
> > for example, it used to be named BXPCSSDT, now it's BXPC.
> >
> > Pls keep using build_header, this problem will go away then.
> [...]
> > > + /* Init SSDT Definition Block */
> > > + ssdt = aml_def_block("SSDT", 1, ACPI_BUILD_APPNAME6,
> > > + ACPI_BUILD_APPNAME4, 1,
> I've missed that build_header() composes oem_table_id implicitly
> by merging table signature and ACPI_BUILD_APPNAME4.
>
> following should fix issue:
> - ACPI_BUILD_APPNAME4, 1,
> + "BXPCSSDT", 1,
True but that's the result of code duplication.
Let's reuse build_header at step 1,
and in step 2, we'll replace it with something
else everywhere.
> > > + ACPI_BUILD_APPNAME4_HEX, 1);
- Re: [Qemu-devel] [PATCH v3 01/52] acpi: introduce AML composer aml_append(), (continued)
Re: [Qemu-devel] [PATCH v3 01/52] acpi: introduce AML composer aml_append(), Michael S. Tsirkin, 2015/02/17
[Qemu-devel] [PATCH v3 09/52] acpi: add aml_device() term, Igor Mammedov, 2015/02/09
[Qemu-devel] [PATCH v3 10/52] acpi: add aml_method() term, Igor Mammedov, 2015/02/09
[Qemu-devel] [PATCH v3 08/52] pc: acpi-build: use aml_scope() for \_SB scope, Igor Mammedov, 2015/02/09
[Qemu-devel] [PATCH v3 06/52] pc: acpi-build: use aml_def_block() for declaring SSDT table, Igor Mammedov, 2015/02/09
[Qemu-devel] [PATCH v3 07/52] acpi: add aml_scope() term, Igor Mammedov, 2015/02/09
[Qemu-devel] [PATCH v3 05/52] acpi: add aml_def_block() term, Igor Mammedov, 2015/02/09
Re: [Qemu-devel] [PATCH v3 05/52] acpi: add aml_def_block() term, Michael S. Tsirkin, 2015/02/17
Re: [Qemu-devel] [PATCH v3 05/52] acpi: add aml_def_block() term, Igor Mammedov, 2015/02/18
Re: [Qemu-devel] [PATCH v3 05/52] acpi: add aml_def_block() term, Michael S. Tsirkin, 2015/02/18