[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] linux-user: Correct TARGET_NR_timerfd to TARGET
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH] linux-user: Correct TARGET_NR_timerfd to TARGET_NR_timerfd_create. |
Date: |
Wed, 8 Apr 2015 21:31:35 +0100 |
On 8 April 2015 at 21:30, Peter Maydell <address@hidden> wrote:
> On 8 April 2015 at 21:26, Timothy E Baldwin
> <address@hidden> wrote:
>> Misspelled system call name in macro was causing timerfd_create not to be
>> supported for the ARM target.
>> ---
>> linux-user/arm/syscall_nr.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/linux-user/arm/syscall_nr.h b/linux-user/arm/syscall_nr.h
>> index 7d7be7c..53552be 100644
>> --- a/linux-user/arm/syscall_nr.h
>> +++ b/linux-user/arm/syscall_nr.h
>> @@ -354,7 +354,7 @@
>> #define TARGET_NR_kexec_load (347)
>> #define TARGET_NR_utimensat (348)
>> #define TARGET_NR_signalfd (349)
>> -#define TARGET_NR_timerfd (350)
>> +#define TARGET_NR_timerfd_create (350)
>> #define TARGET_NR_eventfd (351)
>> #define TARGET_NR_fallocate (352)
>> #define TARGET_NR_timerfd_settime (353)
>
> Reviewed-by: Peter Maydell <address@hidden>
...except I've just noticed you haven't added a
Signed-off-by: line in your commit message. We need
this, or we can't apply your patch.
(It would also be good to linewrap your commit messages
at 70-75 columns or so.)
thanks
-- PMM