[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 04/20] hw/acpi/aml-build: Add aml_memory32_fi
From: |
Shannon Zhao |
Subject: |
Re: [Qemu-devel] [PATCH v4 04/20] hw/acpi/aml-build: Add aml_memory32_fixed() term |
Date: |
Fri, 10 Apr 2015 13:49:27 +0800 |
User-agent: |
Mozilla/5.0 (Windows NT 6.1; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 |
On 2015/4/9 20:42, Igor Mammedov wrote:
> On Fri, 3 Apr 2015 18:03:36 +0800
> Shannon Zhao <address@hidden> wrote:
>
>> From: Shannon Zhao <address@hidden>
>>
>> Add aml_memory32_fixed() for describing device mmio region in resource
>> template.
>> These can be used to generating DSDT table for ACPI on ARM.
>>
>> Signed-off-by: Shannon Zhao <address@hidden>
>> Signed-off-by: Shannon Zhao <address@hidden>
>> ---
>> hw/acpi/aml-build.c | 22 ++++++++++++++++++++++
>> include/hw/acpi/aml-build.h | 1 +
>> 2 files changed, 23 insertions(+)
>>
>> diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c
>> index 8d01959..fefe7c7 100644
>> --- a/hw/acpi/aml-build.c
>> +++ b/hw/acpi/aml-build.c
>> @@ -505,6 +505,28 @@ Aml *aml_call4(const char *method, Aml *arg1, Aml
>> *arg2, Aml *arg3, Aml *arg4)
>> return var;
>> }
>>
>> +/*
>> + * ACPI 1.0: 6.4.3.4 Memory32Fixed (Memory Resource Descriptor Macro)
>> + */
>> +Aml *aml_memory32_fixed(uint64_t addr, uint64_t size, uint8_t rw_flag)
> perhaps
> s/uint64_t/uint32_t/
>
> don't use uintXX for bitfields if could be helped.
> Probably in this case existing AmlReadAndWrite enum should be used.
>
Ok, will use the enum.
--
Thanks,
Shannon
[Qemu-devel] [PATCH v4 12/20] hw/arm/virt-acpi-build: Add PCIe info and generate MCFG table, Shannon Zhao, 2015/04/03