[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 13/15] configure: Copy some items from default c
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 13/15] configure: Copy some items from default configs to target configs |
Date: |
Fri, 10 Apr 2015 13:47:10 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 |
On 07/04/2015 21:51, address@hidden wrote:
> From: Corey Minyard <address@hidden>
>
> This is to get CONFIG_ACPI into the target config so devices that may
> use ACPI know to do this or not.
>
> Signed-off-by: Corey Minyard <address@hidden>
> ---
> configure | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/configure b/configure
> index 09c9225..e301259 100755
> --- a/configure
> +++ b/configure
> @@ -5073,6 +5073,9 @@ if test "$linux" = "yes" ; then
> fi
> fi
>
> +# Copy these from the default config to the target config
> +defconfig_to_target="CONFIG_ACPI"
> +
> for target in $target_list; do
> target_dir="$target"
> config_target_mak=$target_dir/config-target.mak
> @@ -5431,6 +5434,10 @@ fi
> echo "LDFLAGS+=$ldflags" >> $config_target_mak
> echo "QEMU_CFLAGS+=$cflags" >> $config_target_mak
>
> +for i in $defconfig_to_target; do
> + grep $i $source_path/default-configs/${target}.mak >>
> $config_target_mak
> +done
> +
> done # for target in $targets
>
> if [ "$pixman" = "internal" ]; then
>
This doesn't support "include" directives.
Also, it's ugly that you have to compile files per-target.
Perhaps you can use something like:
CONFIG_NOT_ACPI := $(call lnot,$(CONFIG_ACPI))
CONFIG_NOT_SMBIOS := $(call lnot,$(CONFIG_SMBIOS))
common-obj-$(CONFIG_ISA_IPMI) += isa_ipmi.o
common-obj-$(call land,$(CONFIG_ISA_IPMI),$(CONFIG_ACPI)) += isa_ipmi-ssdt.o
common-obj-$(call land,$(CONFIG_ISA_IPMI),$(CONFIG_NOT_ACPI)) +=
isa_ipmi-ssdt-stub.o
common-obj-$(call land,$(CONFIG_ISA_IPMI),$(CONFIG_SMBIOS)) +=
isa_ipmi-smbios.o
common-obj-$(call land,$(CONFIG_ISA_IPMI),$(CONFIG_NOT_ACPI)) +=
isa_ipmi-smbios-stub.o
# Make toplevel always build these
common-obj-$(CONFIG_ALL) += isa_ipmi-ssdt-stub.o isa_ipmi-smbios-stub.o
Paolo
- [Qemu-devel] [PATCH 00/15] IPMI device for qemu, minyard, 2015/04/07
- [Qemu-devel] [PATCH 02/15] ipmi: Add a PC ISA type structure, minyard, 2015/04/07
- [Qemu-devel] [PATCH 01/15] Add a base IPMI interface, minyard, 2015/04/07
- [Qemu-devel] [PATCH 08/15] ipmi: Add documentation, minyard, 2015/04/07
- [Qemu-devel] [PATCH 03/15] ipmi: Add a KCS low-level interface, minyard, 2015/04/07
- [Qemu-devel] [PATCH 11/15] pc: Postpone SMBIOS table installation to post machine init, minyard, 2015/04/07
- [Qemu-devel] [PATCH 04/15] ipmi: Add a BT low-level interface, minyard, 2015/04/07
- [Qemu-devel] [PATCH 09/15] ipmi: Add migration capability to the IPMI device., minyard, 2015/04/07
- [Qemu-devel] [PATCH 13/15] configure: Copy some items from default configs to target configs, minyard, 2015/04/07
- Re: [Qemu-devel] [PATCH 13/15] configure: Copy some items from default configs to target configs,
Paolo Bonzini <=
- [Qemu-devel] [PATCH 10/15] smbios: Add a function to directly add an entry, minyard, 2015/04/07
- Re: [Qemu-devel] [PATCH 10/15] smbios: Add a function to directly add an entry, Michael S. Tsirkin, 2015/04/12
- Re: [Qemu-devel] [PATCH 10/15] smbios: Add a function to directly add an entry, Corey Minyard, 2015/04/12
- Re: [Qemu-devel] [PATCH 10/15] smbios: Add a function to directly add an entry, Michael S. Tsirkin, 2015/04/13
- Re: [Qemu-devel] [PATCH 10/15] smbios: Add a function to directly add an entry, Corey Minyard, 2015/04/13
- Re: [Qemu-devel] [PATCH 10/15] smbios: Add a function to directly add an entry, Paolo Bonzini, 2015/04/13
- Re: [Qemu-devel] [PATCH 10/15] smbios: Add a function to directly add an entry, Michael S. Tsirkin, 2015/04/14
- Re: [Qemu-devel] [PATCH 10/15] smbios: Add a function to directly add an entry, Corey Minyard, 2015/04/14
- Re: [Qemu-devel] [PATCH 10/15] smbios: Add a function to directly add an entry, Paolo Bonzini, 2015/04/14
- Re: [Qemu-devel] [PATCH 10/15] smbios: Add a function to directly add an entry, Michael S. Tsirkin, 2015/04/14