[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 01/12 v9] linux-user: tilegx: Firstly add archit
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 01/12 v9] linux-user: tilegx: Firstly add architecture related features |
Date: |
Fri, 10 Apr 2015 22:38:35 +0100 |
On 10 April 2015 at 21:01, Chen Gang <address@hidden> wrote:
>
> Firstly, thank you very much for your patient work for all related
> patches.
>
> And I shall try to send patch v10 within this month, and let linux-user
> run "Hello world" completely (finish emulate a demo executable binary
> successfully).
>
> The related reply is below:
>
> On 4/10/15 05:21, Peter Maydell wrote:
>>> + tilegx_reg_t tp; /* thread-local data */
>>> + tilegx_reg_t sp; /* stack pointer */
>>> + tilegx_reg_t lr; /* lr pointer */
>>
>> This is missing a bunch of stuff from the kernel uapi
>> pt_regs type, which is bad because this struct is part
>> of the user-facing ABI (it gets used in signal handling).
>>
>
> OK, thanks. And I guess, sigcontext is a little betther than pt_regs.
sigcontext is a different struct. The target_pt_regs struct
should match the kernel's pt_regs struct, and the target_sigcontext
should match the kernel's sigcontext struct.
-- PMM