[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RFC 16/19] qobject: Clean up around qtype_code
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH RFC 16/19] qobject: Clean up around qtype_code |
Date: |
Mon, 13 Apr 2015 21:32:43 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 |
On 04/02/2015 11:29 AM, Markus Armbruster wrote:
> QTYPE_NONE is a sentinel value. No QObject has this type code.
> Document it properly.
>
> Fix dump_qobject() to abort() on QTYPE_NONE, just like for any other
> invalid type code.
>
> Fix to_json() to abort() on all invalid type codes, not just
> QTYPE_MAX.
>
> Clean up Property member qtype's type: it's a qtype_code.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> block/qapi.c | 3 ---
> include/hw/qdev-core.h | 2 +-
> include/qapi/qmp/qobject.h | 2 +-
> qobject/qjson.c | 3 +--
> 4 files changed, 3 insertions(+), 7 deletions(-)
>
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH RFC 15/19] qapi: Inline gen_command_decl_prologue(), gen_command_def_prologue(), (continued)
- [Qemu-devel] [PATCH RFC 17/19] qobject: Add a special null QObject, Markus Armbruster, 2015/04/02
- [Qemu-devel] [PATCH RFC 14/19] qapi: Drop pointless flush() before close(), Markus Armbruster, 2015/04/02
- [Qemu-devel] [PATCH RFC 18/19] json-parser: Fix to recognize null, Markus Armbruster, 2015/04/02
- [Qemu-devel] [PATCH RFC 19/19] qapi: New QMP command query-schema for QMP schema introspection, Markus Armbruster, 2015/04/02
- [Qemu-devel] [PATCH RFC 16/19] qobject: Clean up around qtype_code, Markus Armbruster, 2015/04/02
- Re: [Qemu-devel] [PATCH RFC 16/19] qobject: Clean up around qtype_code,
Eric Blake <=
- [Qemu-devel] [PATCH RFC 13/19] qapi: Factor open_output(), close_output() out of generators, Markus Armbruster, 2015/04/02
- [Qemu-devel] [PATCH RFC 10/19] qapi: Factor parse_command_line() out of the generators, Markus Armbruster, 2015/04/02
- [Qemu-devel] [PATCH RFC 11/19] qapi: Fix generators to report command line errors decently, Markus Armbruster, 2015/04/02
- [Qemu-devel] [PATCH RFC 04/19] qapi: Rename generate_enum_full_value() to c_enum_const(), Markus Armbruster, 2015/04/02
- [Qemu-devel] [PATCH RFC 03/19] qapi: Rename _generate_enum_string() to camel_to_upper(), Markus Armbruster, 2015/04/02