Re: [Qemu-devel] [PATCH v2 09/11] qmp: Add an implementation wrapper for qmp_drive_backup

[Max Reitz]

On 27.03.2015 20:20, John Snow wrote:
> We'd like to be able to specify the callback given to backup_start
> manually in the case of transactions, so split apart qmp_drive_backup
> into an implementation and a wrapper.
>
> Switch drive_backup_prepare to use the new wrapper, but don't overload
> the callback and closure yet.
>
> Signed-off-by: John Snow <address@hidden>
> ---
>   blockdev.c | 65 ++++++++++++++++++++++++++++++++++++++++++++------------------
>   1 file changed, 46 insertions(+), 19 deletions(-)

Reviewed-by: Max Reitz <address@hidden>

The problem being that it relies on patch 8. I don't think being able to 
avoid a single forward declaration warrants moving half (or more...) of 
blockdev.c around, but I'm open to be convinced otherwise.

Max