[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] migration: avoid divide by zero in xbzrle cache
From: |
Amit Shah |
Subject: |
Re: [Qemu-devel] [PATCH] migration: avoid divide by zero in xbzrle cache miss rate |
Date: |
Mon, 20 Apr 2015 12:40:21 +0530 |
On (Wed) 15 Apr 2015 [13:59:14], Michael Chapman wrote:
> This bug manifested itself as a VM that could not be resumed by libvirt
> following a migration:
>
> # virsh resume example
> error: Failed to resume domain example
> error: internal error: cannot parse json {"return":
> {"xbzrle-cache":
> {..., "cache-miss-rate": -nan, ...},
> ...
> }
> }: lexical error: malformed number, a digit is required after the minus
> sign.
>
> This patch also ensures xbzrle_cache_miss_prev and iterations_prev are
> cleared at the start of the migration.
>
> Signed-off-by: Michael Chapman <address@hidden>
Reviewed-by: Amit Shah <address@hidden>
Amit