[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 5/6] [wip] tseg, part1, not (yet) tested
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [PATCH 5/6] [wip] tseg, part1, not (yet) tested |
Date: |
Thu, 23 Apr 2015 09:02:30 +0200 |
Hi,
> > The third one is messy. It relies on SMI_EN, which is an ioport at
> > PMBA+0x30. It requires a configured PMBA.
Isn't that initialized early anyway, because the pm timer lives there?
It's not a regular pci bar exactly to allow early init, so the full pci
bus scan + bar allocation done later will not mess up things.
[ just a question, could very well be that even when initialized early
it isn't early enough because you need to know the memory layout
before uncompressing the firmware modules ]
> There's another problem with basing this decision in OVMF on
> SMI_EN.APMC_EN: it is not an idempotent check. At some point the
> firmware itself has to set SMI_EN.APMC_EN.
Yep, you'll need some variable saying whenever smm is there or not and
check that. Because of this. Or (in case we are going for the fw_cfg
file) because you don't want dig into fw_cfg each time you need to know
this.
cheers,
Gerd
- Re: [Qemu-devel] [PATCH 5/6] [wip] tseg, part1, not (yet) tested, (continued)
- Re: [Qemu-devel] [PATCH 5/6] [wip] tseg, part1, not (yet) tested, Gerd Hoffmann, 2015/04/21
- Re: [Qemu-devel] [PATCH 5/6] [wip] tseg, part1, not (yet) tested, Paolo Bonzini, 2015/04/21
- Re: [Qemu-devel] [PATCH 5/6] [wip] tseg, part1, not (yet) tested, Gerd Hoffmann, 2015/04/21
- Re: [Qemu-devel] [PATCH 5/6] [wip] tseg, part1, not (yet) tested, Laszlo Ersek, 2015/04/21
- Re: [Qemu-devel] [PATCH 5/6] [wip] tseg, part1, not (yet) tested, Gerd Hoffmann, 2015/04/22
- Re: [Qemu-devel] [PATCH 5/6] [wip] tseg, part1, not (yet) tested, Gerd Hoffmann, 2015/04/22
- Re: [Qemu-devel] [PATCH 5/6] [wip] tseg, part1, not (yet) tested, Laszlo Ersek, 2015/04/22
- Re: [Qemu-devel] [PATCH 5/6] [wip] tseg, part1, not (yet) tested, Gerd Hoffmann, 2015/04/22
- Re: [Qemu-devel] [PATCH 5/6] [wip] tseg, part1, not (yet) tested, Laszlo Ersek, 2015/04/22
- Re: [Qemu-devel] [PATCH 5/6] [wip] tseg, part1, not (yet) tested, Laszlo Ersek, 2015/04/22
- Re: [Qemu-devel] [PATCH 5/6] [wip] tseg, part1, not (yet) tested,
Gerd Hoffmann <=
- Re: [Qemu-devel] [PATCH 5/6] [wip] tseg, part1, not (yet) tested, Laszlo Ersek, 2015/04/23
- Re: [Qemu-devel] [PATCH 5/6] [wip] tseg, part1, not (yet) tested, Laszlo Ersek, 2015/04/23
- Re: [Qemu-devel] [PATCH 5/6] [wip] tseg, part1, not (yet) tested, Gerd Hoffmann, 2015/04/23
- Re: [Qemu-devel] [PATCH 5/6] [wip] tseg, part1, not (yet) tested, Laszlo Ersek, 2015/04/23
- Re: [Qemu-devel] [PATCH 5/6] [wip] tseg, part1, not (yet) tested, Paolo Bonzini, 2015/04/23
[Qemu-devel] [PATCH 6/6] [wip] tseg, part2, not (yet) tested, Gerd Hoffmann, 2015/04/20
- Re: [Qemu-devel] [PATCH 6/6] [wip] tseg, part2, not (yet) tested, Laszlo Ersek, 2015/04/21
- Re: [Qemu-devel] [PATCH 6/6] [wip] tseg, part2, not (yet) tested, Paolo Bonzini, 2015/04/21
- Re: [Qemu-devel] [PATCH 6/6] [wip] tseg, part2, not (yet) tested, Laszlo Ersek, 2015/04/21
- Re: [Qemu-devel] [PATCH 6/6] [wip] tseg, part2, not (yet) tested, Gerd Hoffmann, 2015/04/21