[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH target-arm v4 16/16] arm: xlnx-zynqmp: Add PSCI
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH target-arm v4 16/16] arm: xlnx-zynqmp: Add PSCI setup |
Date: |
Thu, 23 Apr 2015 19:16:37 +0100 |
On 23 March 2015 at 11:05, Peter Crosthwaite
<address@hidden> wrote:
> Use SMC PSCI, with the standard policy of secondaries starting in
> power-off.
>
> Reviewed-by: Alistair Francis <address@hidden>
> Signed-off-by: Peter Crosthwaite <address@hidden>
> ---
> changed since v1:
> Add &error_abort to property setter calls
>
> hw/arm/xlnx-zynqmp.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/hw/arm/xlnx-zynqmp.c b/hw/arm/xlnx-zynqmp.c
> index e015025..0265fba 100644
> --- a/hw/arm/xlnx-zynqmp.c
> +++ b/hw/arm/xlnx-zynqmp.c
> @@ -97,6 +97,14 @@ static void xlnx_zynqmp_realize(DeviceState *dev, Error
> **errp)
> for (i = 0; i < XLNX_ZYNQMP_NUM_CPUS; i++) {
> qemu_irq irq;
>
> + object_property_set_int(OBJECT(&s->cpu[i]), QEMU_PSCI_CONDUIT_SMC,
> + "psci-conduit", &error_abort);
> + if (i > 0) {
> + /* Secondary CPUs start in PSCI powered-down state */
> + object_property_set_bool(OBJECT(&s->cpu[i]), true,
> + "start-powered-off", &error_abort);
> + }
...oh, here's the PSCI config. I think you might as well have
rolled this into the initial "create the CPUs" patch.
-- PMM
- Re: [Qemu-devel] [PATCH target-arm v4 16/16] arm: xlnx-zynqmp: Add PSCI setup,
Peter Maydell <=