[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 16/36] qapi: Use 'alternate' to replace anony
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v6 16/36] qapi: Use 'alternate' to replace anonymous union |
Date: |
Tue, 28 Apr 2015 11:29:46 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 |
On 04/28/2015 02:41 AM, Markus Armbruster wrote:
> Eric Blake <address@hidden> writes:
>
>> Previous patches have led up to the point where I create the
>> new meta-type "'alternate':'Foo'". See the previous patches
>> for documentation; I intentionally split as much work into
>> earlier patches to minimize the size of this patch, but a lot
>> of it is churn due to testsuite fallout after updating to the
>> new type.
>>
>> Signed-off-by: Eric Blake <address@hidden>
> [...]
>> diff --git a/tests/qapi-schema/flat-union-base-union.json
>> b/tests/qapi-schema/flat-union-base-union.json
>> index 838986c..0ba6e28 100644
>> --- a/tests/qapi-schema/flat-union-base-union.json
>> +++ b/tests/qapi-schema/flat-union-base-union.json
>> @@ -1,4 +1,4 @@
>> -# FIXME: the error message needs help: we require the base to be a struct
>> +# we require the base to be a struct
>> { 'enum': 'TestEnum',
>> 'data': [ 'value1', 'value2' ] }
>> { 'type': 'TestTypeA',
>
> This looks unrelated. Does it belong to PATCH 25?
Uggh - more evidence of botched hunk motion across rebase.
>
> [...]
>
> Regardless,
> Reviewed-by: Markus Armbruster <address@hidden>
End result is the same, so unless I need to rebase on top of all the
other patches going in right now, I won't bother to respin.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH v6 11/36] qapi: Tighten checking of unions, (continued)
- [Qemu-devel] [PATCH v6 21/36] qapi: Allow true, false and null in schema json, Eric Blake, 2015/04/05
- [Qemu-devel] [PATCH v6 17/36] qapi: Add some expr tests, Eric Blake, 2015/04/05
- [Qemu-devel] [PATCH v6 19/36] qapi: Add tests of redefined expressions, Eric Blake, 2015/04/05
- [Qemu-devel] [PATCH v6 22/36] qapi: Unify type bypass and add tests, Eric Blake, 2015/04/05
- [Qemu-devel] [PATCH v6 18/36] qapi: Better error messages for bad expressions, Eric Blake, 2015/04/05
- [Qemu-devel] [PATCH v6 16/36] qapi: Use 'alternate' to replace anonymous union, Eric Blake, 2015/04/05
- [Qemu-devel] [PATCH v6 20/36] qapi: Better error messages for duplicated expressions, Eric Blake, 2015/04/05
- [Qemu-devel] [PATCH v6 08/36] qapi: Add some union tests, Eric Blake, 2015/04/05
- [Qemu-devel] [PATCH v6 26/36] qapi: Whitelist commands that don't return dictionary, Eric Blake, 2015/04/05
- [Qemu-devel] [PATCH v6 27/36] qapi: More rigorous checking for type safety bypass, Eric Blake, 2015/04/05
- [Qemu-devel] [PATCH v6 25/36] qapi: Require valid names, Eric Blake, 2015/04/05
- [Qemu-devel] [PATCH v6 24/36] qapi: More rigourous checking of types, Eric Blake, 2015/04/05