[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [RFC PATCH 3/8] l2tpv3: Drop l2tpv3_can_send
From: |
Fam Zheng |
Subject: |
[Qemu-devel] [RFC PATCH 3/8] l2tpv3: Drop l2tpv3_can_send |
Date: |
Wed, 29 Apr 2015 18:37:50 +0800 |
This callback is called by main loop before polling s->fd, if it returns
false, the fd will not be polled in this iteration.
This is redundant with checks inside read callback. After this patch,
the data will be copied from s->fd to s->msgvec when it arrives. If the
device can't receive, it will be queued to incoming_queue, and when the
device status changes, this queue will be flushed.
Signed-off-by: Fam Zheng <address@hidden>
---
net/l2tpv3.c | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/net/l2tpv3.c b/net/l2tpv3.c
index 8c598b0..8eed06b 100644
--- a/net/l2tpv3.c
+++ b/net/l2tpv3.c
@@ -133,14 +133,12 @@ typedef struct NetL2TPV3State {
} NetL2TPV3State;
-static int l2tpv3_can_send(void *opaque);
static void net_l2tpv3_send(void *opaque);
static void l2tpv3_writable(void *opaque);
static void l2tpv3_update_fd_handler(NetL2TPV3State *s)
{
- qemu_set_fd_handler2(s->fd,
- s->read_poll ? l2tpv3_can_send : NULL,
+ qemu_set_fd_handler2(s->fd, NULL,
s->read_poll ? net_l2tpv3_send : NULL,
s->write_poll ? l2tpv3_writable : NULL,
s);
@@ -169,13 +167,6 @@ static void l2tpv3_writable(void *opaque)
qemu_flush_queued_packets(&s->nc);
}
-static int l2tpv3_can_send(void *opaque)
-{
- NetL2TPV3State *s = opaque;
-
- return qemu_can_send_packet(&s->nc);
-}
-
static void l2tpv3_send_completed(NetClientState *nc, ssize_t len)
{
NetL2TPV3State *s = DO_UPCAST(NetL2TPV3State, nc, nc);
--
1.9.3
- [Qemu-devel] [RFC PATCH 0/8] main-loop: Get rid of fd_read_poll and qemu_set_fd_handler2, Fam Zheng, 2015/04/29
- [Qemu-devel] [RFC PATCH 2/8] qemu-nbd: Switch to qemu_set_fd_handler, Fam Zheng, 2015/04/29
- [Qemu-devel] [RFC PATCH 1/8] stubs: Add qemu_set_fd_handler, Fam Zheng, 2015/04/29
- [Qemu-devel] [RFC PATCH 4/8] netmap: Drop netmap_can_send, Fam Zheng, 2015/04/29
- [Qemu-devel] [RFC PATCH 3/8] l2tpv3: Drop l2tpv3_can_send,
Fam Zheng <=
- [Qemu-devel] [RFC PATCH 5/8] net/socket: Drop net_socket_can_send, Fam Zheng, 2015/04/29
- [Qemu-devel] [RFC PATCH 7/8] Change qemu_set_fd_handler2(..., NULL, ...) to qemu_set_fd_handler, Fam Zheng, 2015/04/29
- [Qemu-devel] [RFC PATCH 6/8] tap: Drop tap_can_send, Fam Zheng, 2015/04/29
- [Qemu-devel] [RFC PATCH 8/8] main-loop: Drop qemu_set_fd_handler2, Fam Zheng, 2015/04/29