[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 00/36] drop qapi nested structs
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v6 00/36] drop qapi nested structs |
Date: |
Wed, 29 Apr 2015 06:34:12 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 |
On 04/29/2015 12:48 AM, Markus Armbruster wrote:
> General question first: through which tree should this go?
>
> MAINTAINERS doesn't cover the QAPI generators. Closest related stanza
> is QAPI (Luiz, Michael R.). Should it cover the generators? Next
> closest is QAPI Schema (Luiz, you, myself).
>
> For completeness: because we touch qmp_query_pci_bridge() and
> qmp_query_pci_devices(), get_maintainers.pl also fingers the PCI tree.
>
> If nobody objects, I can take it through my tree. Cc'ing the
> maintainers just mentioned to give them a chance to chime in.
Works for me, but that means we may want to also add the qapi generators
into MAINTAINERS along-side QAPI Schema for future changes. Of course,
as a separate patch.
>> Easier as a followup? Respin just the one patch? Or bite the bullet and
>> rebase the entire series (fixing the other trivial items and adding R-b
>> along the way)?
>
> I think we can either
>
> * Respin, but keep the changes really simple. Feel free to leave some
> issues to followup patches.
Changes in the qapi schema (new structs) require a rebase, so respin on
its way.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH v6 30/36] qapi: Use 'struct' instead of 'type' in schema, (continued)