[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 10/10] kvm: better advice for failed s390x startup
From: |
Cornelia Huck |
Subject: |
[Qemu-devel] [PULL 10/10] kvm: better advice for failed s390x startup |
Date: |
Thu, 30 Apr 2015 14:02:10 +0200 |
If KVM_CREATE failed on s390x, we print a hint to enable the switch_amode
kernel parameter. This only applies to old kernels, and only if the
error was -EINVAL. Moreover, with new kernels, the most likely reason
for -EINVAL is that pgstes were not enabled.
Let's update the error message to give a better hint on where things
may need fixing.
Acked-by: Christian Borntraeger <address@hidden>
Signed-off-by: Cornelia Huck <address@hidden>
---
kvm-all.c | 13 +++++++++++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/kvm-all.c b/kvm-all.c
index 2a717e5..3f7061a 100644
--- a/kvm-all.c
+++ b/kvm-all.c
@@ -1544,8 +1544,17 @@ static int kvm_init(MachineState *ms)
strerror(-ret));
#ifdef TARGET_S390X
- fprintf(stderr, "Please add the 'switch_amode' kernel parameter to "
- "your host kernel command line\n");
+ if (ret == -EINVAL) {
+ fprintf(stderr,
+ "Host kernel setup problem detected. Please verify:\n");
+ fprintf(stderr, "- for kernels supporting the switch_amode or"
+ " user_mode parameters, whether\n");
+ fprintf(stderr,
+ " user space is running in primary address space\n");
+ fprintf(stderr,
+ "- for kernels supporting the vm.allocate_pgste sysctl, "
+ "whether it is enabled\n");
+ }
#endif
goto err;
}
--
2.3.7
- [Qemu-devel] [PULL 00/10] first pile of s390x patches for 2.4, Cornelia Huck, 2015/04/30
- [Qemu-devel] [PULL 03/10] sclp: sort into categories, Cornelia Huck, 2015/04/30
- [Qemu-devel] [PULL 07/10] s390x/kvm: Put vm name, extended name and UUID into STSI322 SYSIB, Cornelia Huck, 2015/04/30
- [Qemu-devel] [PULL 04/10] s390x/ipl: sort into categories, Cornelia Huck, 2015/04/30
- [Qemu-devel] [PULL 02/10] s390-virtio: sort into categories, Cornelia Huck, 2015/04/30
- [Qemu-devel] [PULL 08/10] s390x/mmu: Use ioctl for reading and writing from/to guest memory, Cornelia Huck, 2015/04/30
- [Qemu-devel] [PULL 09/10] s390x/kvm: Support access register mode for KVM_S390_MEM_OP ioctl, Cornelia Huck, 2015/04/30
- [Qemu-devel] [PULL 10/10] kvm: better advice for failed s390x startup,
Cornelia Huck <=
- [Qemu-devel] [PULL 05/10] s390x/mmu: Use access type definitions instead of magic values, Cornelia Huck, 2015/04/30
- [Qemu-devel] [PULL 06/10] linux-headers: update, Cornelia Huck, 2015/04/30
- [Qemu-devel] [PULL 01/10] virtio-ccw: sort into categories, Cornelia Huck, 2015/04/30
- Re: [Qemu-devel] [PULL 00/10] first pile of s390x patches for 2.4, Peter Maydell, 2015/04/30