[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] tests: consolidate common includes under libqte
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH] tests: consolidate common includes under libqtest.h |
Date: |
Tue, 05 May 2015 12:28:55 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 |
On 01/05/2015 00:21, Emilio G. Cota wrote:
> Something like the appended?
>
> Cheers,
>
> Emilio
Pretty good, but I wouldn't use qemu-common.h, at least not until all
the function and macro declarations are moved to separate headers (some
of them may indeed move to osdep.h, in fact).
Paolo
> commit eb415d0695bb49d9df78aedaf4ed3c7083a1a574
> Author: Emilio G. Cota <address@hidden>
> Date: Thu Apr 30 18:00:01 2015 -0400
>
> tests: consolidate common includes under libqtest.h
>
> Source files in tests/ include very common headers,
> such as glib.h or qemu/osdep.h.
>
> Consolidate these includes by including qemu-common.h from
> libqtest.h, which is a common include in tests/.
>
> Two things worth mentioning:
>
> - i440fx-test drops its ARRAY_SIZE definition, which comes now
> from osdep.h via qemu-common.h.
>
> - vhost-user-test.c does keep its include of glib.h, since
> it has to do some contortions to support old glib versions.
> See commit "bd95939f qtest: fix qtest for vhost-user".
>
> Signed-off-by: Emilio G. Cota <address@hidden>
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH] tests: consolidate common includes under libqtest.h,
Paolo Bonzini <=