[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/4] block: Remove bdrv_reset_dirty
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 2/4] block: Remove bdrv_reset_dirty |
Date: |
Tue, 05 May 2015 15:57:12 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 |
On 05/05/2015 06:46 AM, Fam Zheng wrote:
> Using this function woule always be wrong because a dirty bitmap must
s/woule/would/
> have a specific owner that consumes the dirty bits and calls
> bdrv_reset_dirty_bitmap().
>
> Remove the unused function to avoid future misuse.
>
> Signed-off-by: Fam Zheng <address@hidden>
> ---
> block.c | 12 ------------
> include/block/block_int.h | 2 --
> 2 files changed, 14 deletions(-)
>
Reviewed-by Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 0/4] block: Mirror discarded sectors, Fam Zheng, 2015/05/05
- [Qemu-devel] [PATCH 1/4] block: Fix dirty bitmap in bdrv_co_discard, Fam Zheng, 2015/05/05
- Re: [Qemu-devel] [PATCH 1/4] block: Fix dirty bitmap in bdrv_co_discard, Paolo Bonzini, 2015/05/05
- Re: [Qemu-devel] [PATCH 1/4] block: Fix dirty bitmap in bdrv_co_discard, Fam Zheng, 2015/05/05
- Re: [Qemu-devel] [PATCH 1/4] block: Fix dirty bitmap in bdrv_co_discard, Paolo Bonzini, 2015/05/06
- Re: [Qemu-devel] [PATCH 1/4] block: Fix dirty bitmap in bdrv_co_discard, Fam Zheng, 2015/05/06
- Re: [Qemu-devel] [PATCH 1/4] block: Fix dirty bitmap in bdrv_co_discard, Paolo Bonzini, 2015/05/06
- Re: [Qemu-devel] [PATCH 1/4] block: Fix dirty bitmap in bdrv_co_discard, Fam Zheng, 2015/05/11
- Re: [Qemu-devel] [PATCH 1/4] block: Fix dirty bitmap in bdrv_co_discard, Paolo Bonzini, 2015/05/11
[Qemu-devel] [PATCH 2/4] block: Remove bdrv_reset_dirty, Fam Zheng, 2015/05/05
- Re: [Qemu-devel] [PATCH 2/4] block: Remove bdrv_reset_dirty,
Eric Blake <=
[Qemu-devel] [PATCH 3/4] qemu-iotests: Make block job methods common, Fam Zheng, 2015/05/05
[Qemu-devel] [PATCH 4/4] qemu-iotests: Add test case for mirror with unmap, Fam Zheng, 2015/05/05