[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 09/15] migration: Make compression co-work with xbzrl
From: |
Juan Quintela |
Subject: |
[Qemu-devel] [PULL 09/15] migration: Make compression co-work with xbzrle |
Date: |
Wed, 6 May 2015 19:49:58 +0200 |
From: Liang Li <address@hidden>
Now, multiple thread compression can co-work with xbzrle. when
xbzrle is on, multiple thread compression will only work at the
first round of RAM data sync.
Signed-off-by: Liang Li <address@hidden>
Signed-off-by: Yang Zhang <address@hidden>
Reviewed-by: Dr.David Alan Gilbert <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>
---
arch_init.c | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/arch_init.c b/arch_init.c
index 9f63c0f..b81acc9 100644
--- a/arch_init.c
+++ b/arch_init.c
@@ -349,6 +349,8 @@ static QemuMutex *comp_done_lock;
static QemuCond *comp_done_cond;
/* The empty QEMUFileOps will be used by file in CompressParam */
static const QEMUFileOps empty_ops = { };
+
+static bool compression_switch;
static bool quit_comp_thread;
static bool quit_decomp_thread;
static DecompressParam *decomp_param;
@@ -435,6 +437,7 @@ void migrate_compress_threads_create(void)
return;
}
quit_comp_thread = false;
+ compression_switch = true;
thread_count = migrate_compress_threads();
compress_threads = g_new0(QemuThread, thread_count);
comp_param = g_new0(CompressParam, thread_count);
@@ -1060,9 +1063,16 @@ static int ram_find_and_save_block(QEMUFile *f, bool
last_stage,
block = QLIST_FIRST_RCU(&ram_list.blocks);
complete_round = true;
ram_bulk_stage = false;
+ if (migrate_use_xbzrle()) {
+ /* If xbzrle is on, stop using the data compression at this
+ * point. In theory, xbzrle can do better than compression.
+ */
+ flush_compressed_data(f);
+ compression_switch = false;
+ }
}
} else {
- if (migrate_use_compression()) {
+ if (compression_switch && migrate_use_compression()) {
pages = ram_save_compressed_page(f, block, offset, last_stage,
bytes_transferred);
} else {
--
2.4.0
- [Qemu-devel] [PULL 00/15] migration pull request, Juan Quintela, 2015/05/06
- [Qemu-devel] [PULL 01/15] docs: Add a doc about multiple thread compression, Juan Quintela, 2015/05/06
- [Qemu-devel] [PULL 04/15] qemu-file: Add compression functions to QEMUFile, Juan Quintela, 2015/05/06
- [Qemu-devel] [PULL 05/15] arch_init: Alloc and free data struct for compression, Juan Quintela, 2015/05/06
- [Qemu-devel] [PULL 02/15] migration: Add the framework of multi-thread compression, Juan Quintela, 2015/05/06
- [Qemu-devel] [PULL 06/15] arch_init: Add and free data struct for decompression, Juan Quintela, 2015/05/06
- [Qemu-devel] [PULL 03/15] migration: Add the framework of multi-thread decompression, Juan Quintela, 2015/05/06
- [Qemu-devel] [PULL 07/15] migration: Split save_zero_page from ram_save_page, Juan Quintela, 2015/05/06
- [Qemu-devel] [PULL 08/15] migration: Add the core code of multi-thread compression, Juan Quintela, 2015/05/06
- [Qemu-devel] [PULL 09/15] migration: Make compression co-work with xbzrle,
Juan Quintela <=
- [Qemu-devel] [PULL 10/15] migration: Add the core code for decompression, Juan Quintela, 2015/05/06
- [Qemu-devel] [PULL 11/15] migration: Add interface to control compression, Juan Quintela, 2015/05/06
- [Qemu-devel] [PULL 15/15] migration: avoid divide by zero in xbzrle cache miss rate, Juan Quintela, 2015/05/06
- [Qemu-devel] [PULL 13/15] migration: Add qmp commands to set and query parameters, Juan Quintela, 2015/05/06
- [Qemu-devel] [PULL 12/15] migration: Use an array instead of 3 parameters, Juan Quintela, 2015/05/06
- [Qemu-devel] [PULL 14/15] migration: Add hmp interface to set and query parameters, Juan Quintela, 2015/05/06
- Re: [Qemu-devel] [PULL 00/15] migration pull request, Peter Maydell, 2015/05/06