[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 23/28] qmp-event: add event notification for memo
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PULL 23/28] qmp-event: add event notification for memory hot unplug error |
Date: |
Mon, 11 May 2015 09:03:25 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 |
On 05/11/2015 06:48 AM, Michael S. Tsirkin wrote:
> From: Zhu Guihua <address@hidden>
>
> When memory hot unplug fails, this patch adds support to send
> QMP event to notify mgmt about this failure.
>
> Reviewed-by: Igor Mammedov <address@hidden>
> Signed-off-by: Zhu Guihua <address@hidden>
> Reviewed-by: Michael S. Tsirkin <address@hidden>
> Signed-off-by: Michael S. Tsirkin <address@hidden>
> ---
> qapi/event.json | 14 ++++++++++++++
> hw/acpi/memory_hotplug.c | 10 +++++++++-
> docs/qmp/qmp-events.txt | 17 +++++++++++++++++
> trace-events | 1 +
> 4 files changed, 41 insertions(+), 1 deletion(-)
I missed reviewing this earlier; and since it is now in a PULL request,
you'll need a followup patch:
> +
> +##
> +# @MEM_UNPLUG_ERROR
> +#
> +# Emitted when memory hot unplug error occurs.
> +#
> +# @device: device name
> +#
> +# @msg: Informative message
> +#
> +# Since: 2.4
> +##
> +{ 'event': 'MEM_UNPLUG_ERROR',
The name here...
> +++ b/docs/qmp/qmp-events.txt
> @@ -226,6 +226,23 @@ Example:
> { "event": "GUEST_PANICKED",
> "data": { "action": "pause" } }
>
> +MEM_HOT_UNPLUG_ERROR
...needs to be the same one used here.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PULL 15/28] virtio: coding style tweak, (continued)
- [Qemu-devel] [PULL 15/28] virtio: coding style tweak, Michael S. Tsirkin, 2015/05/11
- [Qemu-devel] [PULL 18/28] acpi, mem-hotplug: add unplug request cb for memory device, Michael S. Tsirkin, 2015/05/11
- [Qemu-devel] [PULL 19/28] acpi, mem-hotplug: add unplug cb for memory device, Michael S. Tsirkin, 2015/05/11
- [Qemu-devel] [PULL 21/28] acpi: fix "Memory device control fields" register, Michael S. Tsirkin, 2015/05/11
- [Qemu-devel] [PULL 20/28] acpi: extend aml_field() to support UpdateRule, Michael S. Tsirkin, 2015/05/11
- [Qemu-devel] [PULL 24/28] acpi: add a missing backslash to the \_SB scope., Michael S. Tsirkin, 2015/05/11
- [Qemu-devel] [PULL 25/28] pci: Merge pci_nic_init() into pci_nic_init_nofail(), Michael S. Tsirkin, 2015/05/11
- [Qemu-devel] [PULL 22/28] acpi: add hardware implementation for memory hot unplug, Michael S. Tsirkin, 2015/05/11
- [Qemu-devel] [PULL 28/28] acpi: update expected files for memory unplug, Michael S. Tsirkin, 2015/05/11
- [Qemu-devel] [PULL 23/28] qmp-event: add event notification for memory hot unplug error, Michael S. Tsirkin, 2015/05/11
- Re: [Qemu-devel] [PULL 23/28] qmp-event: add event notification for memory hot unplug error,
Eric Blake <=
- [Qemu-devel] [PULL 26/28] virtio-net: Move DEFINE_VIRTIO_NET_FEATURES to virtio-net, Michael S. Tsirkin, 2015/05/11
- [Qemu-devel] [PULL 27/28] virtio-scsi: Move DEFINE_VIRTIO_SCSI_FEATURES to virtio-scsi, Michael S. Tsirkin, 2015/05/11
- Re: [Qemu-devel] [PULL 00/28] pc, virtio enhancements, Peter Maydell, 2015/05/12