[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 3/6] console-gl: add opengl rendering helper func
From: |
Alexander Graf |
Subject: |
Re: [Qemu-devel] [PULL 3/6] console-gl: add opengl rendering helper functions |
Date: |
Mon, 11 May 2015 22:32:04 +0200 |
User-agent: |
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 |
On 08.05.15 08:24, Gerd Hoffmann wrote:
> On Fr, 2015-05-08 at 00:28 +0200, Alexander Graf wrote:
>>
>> On 05.05.15 11:43, Gerd Hoffmann wrote:
>>> Signed-off-by: Gerd Hoffmann <address@hidden>
>>> Reviewed-by: Max Reitz <address@hidden>
>>> ---
>>
>> [...]
>>
>>> +void surface_gl_create_texture(ConsoleGLState *gls,
>>> + DisplaySurface *surface)
>>> +{
>>> + assert(gls);
>>> + assert(surface_stride(surface) % surface_bytes_per_pixel(surface) ==
>>> 0);
>>> +
>>> + switch (surface->format) {
>>> + case PIXMAN_BE_b8g8r8x8:
>>> + case PIXMAN_BE_b8g8r8a8:
>>> + surface->glformat = GL_BGRA_EXT;
>>> + surface->gltype = GL_UNSIGNED_BYTE;
>>> + break;
>>> + case PIXMAN_r5g6b5:
>>> + surface->glformat = GL_RGB;
>>> + surface->gltype = GL_UNSIGNED_SHORT_5_6_5;
>>> + break;
>>> + default:
>>> + g_assert_not_reached();
>>> + }
>>> +
>>> + glGenTextures(1, &surface->texture);
>>> + glEnable(GL_TEXTURE_2D);
>>> + glBindTexture(GL_TEXTURE_2D, surface->texture);
>>> + glPixelStorei(GL_UNPACK_ROW_LENGTH_EXT,
>>
>> This doesn't compile for me on SLES11:
>>
>> ui/console-gl.c: In function ‘surface_gl_create_texture’:
>> ui/console-gl.c:97:19: error: ‘GL_UNPACK_ROW_LENGTH_EXT’ undeclared
>> (first use in this function)
>> ui/console-gl.c:97:19: note: each undeclared identifier is reported only
>> once for each function it appears in
>> ui/console-gl.c: In function ‘surface_gl_update_texture’:
>> ui/console-gl.c:117:19: error: ‘GL_UNPACK_ROW_LENGTH_EXT’ undeclared
>> (first use in this function)
>> make: *** [ui/console-gl.o] Error 1
>> make: *** Waiting for unfinished jobs....
>
> Which mesa version is this?
The one I first saw it on is a PPC SLES11 system:
$ rpm -qa | grep -i mesa
Mesa-libGLESv2-2-9.0.2-34.3.1.ppc64
Mesa-9.0.2-34.3.1.ppc64
Mesa-libEGL1-32bit-9.0.2-34.3.1.ppc64
Mesa-libGL1-32bit-9.0.2-34.3.1.ppc64
Mesa-libglapi-devel-9.0.2-34.3.1.ppc64
Mesa-libGLESv2-2-32bit-9.0.2-34.3.1.ppc64
Mesa-32bit-9.0.2-34.3.1.ppc64
DirectFB-Mesa-1.6.2-3.1.1.ppc64
Mesa-libGLESv2-devel-9.0.2-34.3.1.ppc64
Mesa-libglapi0-9.0.2-34.3.1.ppc64
Mesa-libGL1-9.0.2-34.3.1.ppc64
Mesa-libGL-devel-9.0.2-34.3.1.ppc64
Mesa-libGLESv1_CM-devel-9.0.2-34.3.1.ppc64
Mesa-devel-9.0.2-34.3.1.ppc64
Mesa-libGLESv1_CM1-9.0.2-34.3.1.ppc64
Mesa-libglapi0-32bit-9.0.2-34.3.1.ppc64
libOSMesa9-9.0.2-34.3.1.ppc64
Mesa-libIndirectGL1-9.0.2-34.3.1.ppc64
libOSMesa-devel-9.0.2-34.3.1.ppc64
Mesa-libIndirectGL-devel-9.0.2-34.3.1.ppc64
Mesa-demo-x-8.0.1-8.1.1.ppc64
Mesa-libEGL1-9.0.2-34.3.1.ppc64
Mesa-libEGL-devel-9.0.2-34.3.1.ppc64
But I see the same error on openSUSE 12.3 x86_64 now:
x86:~ # rpm -qa | grep -i mesa
Mesa-libGLESv2-2-9.0.2-34.3.1.x86_64
Mesa-libGL1-9.0.2-34.3.1.x86_64
Mesa-libGLESv2-devel-9.0.2-34.3.1.x86_64
Mesa-libglapi0-9.0.2-34.3.1.x86_64
libOSMesa9-9.0.2-34.3.1.x86_64
Mesa-libEGL1-9.0.2-34.3.1.x86_64
Mesa-9.0.2-34.3.1.x86_64
Mesa-devel-9.0.2-34.3.1.x86_64
Mesa-libIndirectGL-devel-9.0.2-34.3.1.x86_64
Mesa-libEGL-devel-9.0.2-34.3.1.x86_64
Mesa-libglapi-devel-9.0.2-34.3.1.x86_64
libOSMesa-devel-9.0.2-34.3.1.x86_64
Mesa-libGL-devel-9.0.2-34.3.1.x86_64
Mesa-libGLESv1_CM-devel-9.0.2-34.3.1.x86_64
Mesa-libIndirectGL1-9.0.2-34.3.1.x86_64
Mesa-libGLESv1_CM1-9.0.2-34.3.1.x86_64
Alex
- [Qemu-devel] [PULL 0/6] sdl2: add opengl rendering support., Gerd Hoffmann, 2015/05/05
- [Qemu-devel] [PULL 1/6] opengl: add shader build infrastructure, Gerd Hoffmann, 2015/05/05
- [Qemu-devel] [PULL 2/6] opengl: add shader helper functions., Gerd Hoffmann, 2015/05/05
- [Qemu-devel] [PULL 4/6] sdl2: move SDL_* includes to sdl2.h, Gerd Hoffmann, 2015/05/05
- [Qemu-devel] [PULL 6/6] sdl2: Fix RGB555, Gerd Hoffmann, 2015/05/05
- [Qemu-devel] [PULL 3/6] console-gl: add opengl rendering helper functions, Gerd Hoffmann, 2015/05/05
[Qemu-devel] [PULL 5/6] sdl2: add support for display rendering using opengl., Gerd Hoffmann, 2015/05/05
Re: [Qemu-devel] [PULL 0/6] sdl2: add opengl rendering support., Peter Maydell, 2015/05/05