[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH 21/34] arm: Rename all exceptions
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [RFC PATCH 21/34] arm: Rename all exceptions |
Date: |
Fri, 15 May 2015 12:59:24 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 |
Am 15.05.2015 um 07:43 schrieb Peter Crosthwaite:
> On Sun, May 10, 2015 at 11:29 PM, Peter Crosthwaite
> <address@hidden> wrote:
>> These are architecture specific, and via cpu.h visibile in common
>> and global namespaces. Preface them with "ARMAR_" to avoid namespace
>> collisions. Prepares support for multi-arch where multiple cpu.h's
>> can be included by device land code and namespace issues happen with
>> such generic names.
>>
>> Use prefix ARM"AR" as the trap table is separate from the M-profile
>> support, so qualify with AR to make it specific to A/R profile.
ARM_AR_ would sound more appealing to me.
> So I am not exactly sure what to do here going forward. This is going
> to get messy with all the other arches. There are alternatives:
>
> 1: Split these arch-specific private defs to a new header. internals.h
> or a new header. which every way we go though the header needs to be
> exported to linux-user code (awkward).
> 2: Purge all device-land uses of cpu.h. They should be able to use
> cpu-qom.h
Negative, my plans to make cpu-qom.h generally usable failed as env
turned out as embedded struct rather than pointer, and cpu-qom.h thus
depends on stuff defined in cpu.h before its inclusion of cpu-qom.h.
Therefore I told contributors of new targets that the current split
makes no sense for their new targets.
I would prefer 1. independent of whether we rename them or not. We need
a better distinction of internal vs. external for targets.
Regards,
Andreas
> and the random bits of machine-model code reaching into the
> env or strobing interrupts needs to be fixed.
> 3: This patch or something like it.
>
> Regards,
> Peter
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Dilip Upmanyu, Graham Norton; HRB
21284 (AG Nürnberg)
- Re: [Qemu-devel] [RFC PATCH 25/34] arm: cpu: Move CPU_COMMON to front of env, (continued)
- [Qemu-devel] [RFC PATCH 26/34] arm: Use qomified tcg defintions, Peter Crosthwaite, 2015/05/11
- [Qemu-devel] [RFC PATCH 22/34] arm: Remove ELF_MACHINE from cpu.h, Peter Crosthwaite, 2015/05/11
- [Qemu-devel] [RFC PATCH 24/34] arm: delete dummy prototypes, Peter Crosthwaite, 2015/05/11
- [Qemu-devel] [RFC PATCH 23/34] arm: cpu.h: Move cpu-all include, Peter Crosthwaite, 2015/05/11
- [Qemu-devel] [RFC PATCH 20/34] configure: Unify arm and aarch64 disas configury, Peter Crosthwaite, 2015/05/11
- [Qemu-devel] [RFC PATCH 18/34] mb: cpu-qom: Put the ENV first, Peter Crosthwaite, 2015/05/11
- [Qemu-devel] [RFC PATCH 19/34] mb: Enable multi-arch, Peter Crosthwaite, 2015/05/11
- [Qemu-devel] [RFC PATCH 21/34] arm: Rename all exceptions, Peter Crosthwaite, 2015/05/11
[Qemu-devel] [RFC PATCH 16/34] mb: cpu: Guard cpu_init definition for user mode, Peter Crosthwaite, 2015/05/11
[Qemu-devel] [RFC PATCH 15/34] hw: mb: Explicitly include cpu.h for consumers, Peter Crosthwaite, 2015/05/11
[Qemu-devel] [RFC PATCH 13/34] mb: cpu: Change phys and virt address ranges., Peter Crosthwaite, 2015/05/11
[Qemu-devel] [RFC PATCH 11/34] mb: cpu: Remove MMUx macros, Peter Crosthwaite, 2015/05/11
[Qemu-devel] [RFC PATCH 14/34] mb: Use qomified tcg defintions, Peter Crosthwaite, 2015/05/11
[Qemu-devel] [RFC PATCH 17/34] mb: cpu: Multi-define guard deep CPU specifics, Peter Crosthwaite, 2015/05/11
[Qemu-devel] [RFC PATCH 08/34] mb: cpu.h: Move cpu-all include, Peter Crosthwaite, 2015/05/11
[Qemu-devel] [RFC PATCH 12/34] mb: cpu: Move CPU_COMMON to front of env, Peter Crosthwaite, 2015/05/11