[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v8 06/24] hw/acpi/aml-build: Add aml_interrupt()
From: |
Igor Mammedov |
Subject: |
Re: [Qemu-devel] [PATCH v8 06/24] hw/acpi/aml-build: Add aml_interrupt() term |
Date: |
Thu, 21 May 2015 10:17:06 +0200 |
On Thu, 21 May 2015 10:28:33 +0800
Shannon Zhao <address@hidden> wrote:
> From: Shannon Zhao <address@hidden>
>
> Add aml_interrupt() for describing device interrupt in resource template.
> These can be used to generating DSDT table for ACPI on ARM.
>
> Signed-off-by: Shannon Zhao <address@hidden>
> Signed-off-by: Shannon Zhao <address@hidden>
Reviewed-by: Igor Mammedov <address@hidden>
> ---
> hw/acpi/aml-build.c | 27 +++++++++++++++++++++++++++
> include/hw/acpi/aml-build.h | 42 ++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 69 insertions(+)
>
> diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c
> index ad4d7ea..0d99941 100644
> --- a/hw/acpi/aml-build.c
> +++ b/hw/acpi/aml-build.c
> @@ -533,6 +533,33 @@ Aml *aml_memory32_fixed(uint32_t addr, uint32_t size,
> return var;
> }
>
> +/*
> + * ACPI 5.0: 6.4.3.6 Extended Interrupt Descriptor
> + * Type 1, Large Item Name 0x9
> + */
> +Aml *aml_interrupt(AmlConsumerAndProducer con_and_pro,
> + AmlLevelAndEdge level_and_edge,
> + AmlActiveHighAndLow high_and_low, AmlShared shared,
> + uint32_t irq)
> +{
> + Aml *var = aml_alloc();
> + uint8_t irq_flags = con_and_pro | (level_and_edge << 1)
> + | (high_and_low << 2) | (shared << 3);
> +
> + build_append_byte(var->buf, 0x89); /* Extended irq descriptor */
> + build_append_byte(var->buf, 6); /* Length, bits[7:0] minimum value = 6 */
> + build_append_byte(var->buf, 0); /* Length, bits[15:8] minimum value = 0
> */
> + build_append_byte(var->buf, irq_flags); /* Interrupt Vector Information.
> */
> + build_append_byte(var->buf, 0x01); /* Interrupt table length = 1 */
> +
> + /* Interrupt Number */
> + build_append_byte(var->buf, extract32(irq, 0, 8)); /* bits[7:0] */
> + build_append_byte(var->buf, extract32(irq, 8, 8)); /* bits[15:8] */
> + build_append_byte(var->buf, extract32(irq, 16, 8)); /* bits[23:16] */
> + build_append_byte(var->buf, extract32(irq, 24, 8)); /* bits[31:24] */
> + return var;
> +}
> +
> /* ACPI 1.0b: 6.4.2.5 I/O Port Descriptor */
> Aml *aml_io(AmlIODecode dec, uint16_t min_base, uint16_t max_base,
> uint8_t aln, uint8_t len)
> diff --git a/include/hw/acpi/aml-build.h b/include/hw/acpi/aml-build.h
> index bd0d9e7..df23479 100644
> --- a/include/hw/acpi/aml-build.h
> +++ b/include/hw/acpi/aml-build.h
> @@ -111,6 +111,44 @@ typedef enum {
> AML_READ_WRITE = 1,
> } AmlReadAndWrite;
>
> +/*
> + * ACPI 5.0: Table 6-187 Extended Interrupt Descriptor Definition
> + * Interrupt Vector Flags Bits[0] Consumer/Producer
> + */
> +typedef enum {
> + AML_CONSUMER_PRODUCER = 0,
> + AML_CONSUMER = 1,
> +} AmlConsumerAndProducer;
> +
> +/*
> + * ACPI 5.0: Table 6-187 Extended Interrupt Descriptor Definition
> + * _HE field definition
> + */
> +typedef enum {
> + AML_LEVEL = 0,
> + AML_EDGE = 1,
> +} AmlLevelAndEdge;
> +
> +/*
> + * ACPI 5.0: Table 6-187 Extended Interrupt Descriptor Definition
> + * _LL field definition
> + */
> +typedef enum {
> + AML_ACTIVE_HIGH = 0,
> + AML_ACTIVE_LOW = 1,
> +} AmlActiveHighAndLow;
> +
> +/*
> + * ACPI 5.0: Table 6-187 Extended Interrupt Descriptor Definition
> + * _SHR field definition
> + */
> +typedef enum {
> + AML_EXCLUSIVE = 0,
> + AML_SHARED = 1,
> + AML_EXCLUSIVE_AND_WAKE = 2,
> + AML_SHARED_AND_WAKE = 3,
> +} AmlShared;
> +
> typedef
> struct AcpiBuildTables {
> GArray *table_data;
> @@ -170,6 +208,10 @@ Aml *aml_call3(const char *method, Aml *arg1, Aml *arg2,
> Aml *arg3);
> Aml *aml_call4(const char *method, Aml *arg1, Aml *arg2, Aml *arg3, Aml
> *arg4);
> Aml *aml_memory32_fixed(uint32_t addr, uint32_t size,
> AmlReadAndWrite read_and_write);
> +Aml *aml_interrupt(AmlConsumerAndProducer con_and_pro,
> + AmlLevelAndEdge level_and_edge,
> + AmlActiveHighAndLow high_and_low, AmlShared shared,
> + uint32_t irq);
> Aml *aml_io(AmlIODecode dec, uint16_t min_base, uint16_t max_base,
> uint8_t aln, uint8_t len);
> Aml *aml_operation_region(const char *name, AmlRegionSpace rs,
- [Qemu-devel] [PATCH v8 13/24] hw/arm/virt-acpi-build: Generate MCFG table, (continued)
- [Qemu-devel] [PATCH v8 13/24] hw/arm/virt-acpi-build: Generate MCFG table, Shannon Zhao, 2015/05/20
- [Qemu-devel] [PATCH v8 12/24] hw/arm/virt-acpi-build: Generate RSDP table, Shannon Zhao, 2015/05/20
- [Qemu-devel] [PATCH v8 18/24] hw/acpi/aml-build: Add aml_else() term, Shannon Zhao, 2015/05/20
- [Qemu-devel] [PATCH v8 21/24] hw/acpi/aml-build: Add Unicode macro, Shannon Zhao, 2015/05/20
- [Qemu-devel] [PATCH v8 20/24] hw/acpi/aml-build: Add aml_dword_io() term, Shannon Zhao, 2015/05/20
- [Qemu-devel] [PATCH v8 22/24] hw/arm/virt-acpi-build: Add PCIe controller in ACPI DSDT table, Shannon Zhao, 2015/05/20
- [Qemu-devel] [PATCH v8 23/24] ACPI: split CONFIG_ACPI into 4 pieces, Shannon Zhao, 2015/05/20
- [Qemu-devel] [PATCH v8 24/24] hw/arm/virt: Enable dynamic generation of ACPI v5.1 tables, Shannon Zhao, 2015/05/20
- [Qemu-devel] [PATCH v8 11/24] hw/arm/virt-acpi-build: Generate RSDT table, Shannon Zhao, 2015/05/20
- [Qemu-devel] [PATCH v8 06/24] hw/acpi/aml-build: Add aml_interrupt() term, Shannon Zhao, 2015/05/20
- Re: [Qemu-devel] [PATCH v8 06/24] hw/acpi/aml-build: Add aml_interrupt() term,
Igor Mammedov <=
- [Qemu-devel] [PATCH v8 10/24] hw/arm/virt-acpi-build: Generate GTDT table, Shannon Zhao, 2015/05/20
- [Qemu-devel] [PATCH v8 19/24] hw/acpi/aml-build: Add aml_create_dword_field() term, Shannon Zhao, 2015/05/20