[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v8 02/24] hw/arm/virt: Move common definitions t
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v8 02/24] hw/arm/virt: Move common definitions to virt.h |
Date: |
Thu, 21 May 2015 10:19:59 +0100 |
On 21 May 2015 at 09:25, Igor Mammedov <address@hidden> wrote:
> On Thu, 21 May 2015 10:28:29 +0800
> Shannon Zhao <address@hidden> wrote:
>> --- /dev/null
>> +++ b/include/hw/arm/virt.h
>> @@ -0,0 +1,56 @@
>> +/*
>> + *
>> + * Copyright (c) 2015 Linaro Limited
> out of curiosity, git blame - tells that moved code was authored by:
> Laszlo Ersek
> Alexander Graf
> Peter Maydell
> shouldn't they be mentioned here as authors?
Copyright headers are weird things, they don't really fit
well with the "lots of contributors" open source model anyway.
Mostly new files tend to get a copy of the header from the
file the code was moved from, which is what's happened here.
That said, Laszlo and Alex contributed one line each (extra
entries in the enum) and I wrote the rest, and my code is
copyright Linaro anyway. So I think it's fine.
-- PMM
- [Qemu-devel] [PATCH v8 00/24] Generate ACPI v5.1 tables and expose them to guest over fw_cfg on ARM, Shannon Zhao, 2015/05/20
- [Qemu-devel] [PATCH v8 03/24] hw/arm/virt: Record PCIe ranges in MemMapEntry array, Shannon Zhao, 2015/05/20
- [Qemu-devel] [PATCH v8 02/24] hw/arm/virt: Move common definitions to virt.h, Shannon Zhao, 2015/05/20
- [Qemu-devel] [PATCH v8 01/24] hw/acpi/aml-build: Make enum values to be upper case to match coding style, Shannon Zhao, 2015/05/20
- [Qemu-devel] [PATCH v8 04/24] hw/arm/virt-acpi-build: Basic framework for building ACPI tables on ARM, Shannon Zhao, 2015/05/20
- [Qemu-devel] [PATCH v8 14/24] hw/acpi/aml-build: Make aml_buffer() definition consistent with the spec, Shannon Zhao, 2015/05/20
- [Qemu-devel] [PATCH v8 15/24] hw/acpi/aml-build: Add ToUUID macro, Shannon Zhao, 2015/05/20
- [Qemu-devel] [PATCH v8 16/24] hw/acpi/aml-build: Add aml_or() term, Shannon Zhao, 2015/05/20
- [Qemu-devel] [PATCH v8 17/24] hw/acpi/aml-build: Add aml_lnot() term, Shannon Zhao, 2015/05/20