[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RFC 4/4] Initial implementation of vGICv3.
From: |
Pavel Fedin |
Subject: |
Re: [Qemu-devel] [PATCH RFC 4/4] Initial implementation of vGICv3. |
Date: |
Fri, 22 May 2015 19:57:13 +0300 |
Hi!
> Looks GICv3 common class currently miss this security_extn field +
> parent_fiq so it does not compile without changes. Or did I miss something?
Just throw this if(...) away. It's my fault. Actually i have rebased Shlomo's
patches on
yesterday's master, and during this i added parent_fiq[] to GICv3, because
without filling
these in the thing stopped working due to recent GICv2 code changes. I needed
to fix the
problem quickly, so i copied initializing parent_fiq together with
security_extn field
from v2 code. But, this makes no sense because security_extn is never
initialized, it is
not even assigned property name. So just remove this small fragment, it's not
needed now.
I have fixed this in my working tree 2 hours ago. parent_fiq is declared as:
--- cut ---
qemu_irq parent_fiq[GICV3_NCPU];
--- cut ---
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
- [Qemu-devel] [PATCH RFC 1/4] Add virt-v3 machine that uses GIC-500, (continued)