[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RFC V2 2/4] Implment GIC-500
From: |
Shlomo Pongratz |
Subject: |
Re: [Qemu-devel] [PATCH RFC V2 2/4] Implment GIC-500 |
Date: |
Tue, 26 May 2015 08:19:25 +0000 |
> -----Original Message-----
> From: Pavel Fedin [mailto:address@hidden
> Sent: Monday, 25 May, 2015 6:27 PM
> To: 'Eric Auger'; address@hidden; address@hidden;
> Shlomo Pongratz
> Subject: RE: [Qemu-devel] [PATCH RFC V2 2/4] Implment GIC-500
>
> Hi!
>
> > > +static const uint8_t gic_lpi_ids[] = {
> > > + 0x44, 0x00, 0x00, 0x00, 0x093, 0xB4, 0x3B, 0x00, 0x0D, 0xF0,
> > > +0x05, 0xB1 };
>
> Found one more thing. Shouldn't there be 0x091 instead of 0x093 (5th byte =
> PIDR0) ? 0x93 is ITS while REDIST is 0x91.
>
> Kind regards,
> Pavel Fedin
> Expert Engineer
> Samsung Electronics Research center Russia
>
Hi Pavel,
The value is taken from the gic-500 document in the re-distributer's table
(3-7).
I don't know where the value 0x91 comes from as GICD_PIDR0 is 0x92, GICR_PIDR0
is 0x93 and GITS_PIDR0 is 0x94.
In the GICv3 document section 5.4.21 it is also been written:
0xFFE0 GICR_PIDR0 Bits [7:0]. Bits [7:0] of the ARM-defined DevID field. This
field is 0x93 in
ARM implementations of a GICv3 or later Re-distributor.
Best regards,
S.P.
- Re: [Qemu-devel] [PATCH RFC V2 1/4] Use Aff1 with mpidr, (continued)
[Qemu-devel] [PATCH RFC V2 3/4] GICv3 support, shlomopongratz, 2015/05/06
[Qemu-devel] [PATCH RFC V2 2/4] Implment GIC-500, shlomopongratz, 2015/05/06
[Qemu-devel] [PATCH RFC V2 4/4] Add virtv2 machine that uses GIC-500, shlomopongratz, 2015/05/06
- Re: [Qemu-devel] [PATCH RFC V2 4/4] Add virtv2 machine that uses GIC-500, Pavel Fedin, 2015/05/07
- Re: [Qemu-devel] [PATCH RFC V2 4/4] Add virtv2 machine that uses GIC-500, Shlomo Pongratz, 2015/05/07
- Re: [Qemu-devel] [PATCH RFC V2 4/4] Add virtv2 machine that uses GIC-500, Pavel Fedin, 2015/05/07
- Re: [Qemu-devel] [PATCH RFC V2 4/4] Add virtv2 machine that uses GIC-500, Shlomo Pongratz, 2015/05/07
- Re: [Qemu-devel] [PATCH RFC V2 4/4] Add virtv2 machine that uses GIC-500, Pavel Fedin, 2015/05/07
- Re: [Qemu-devel] [PATCH RFC V2 4/4] Add virtv2 machine that uses GIC-500, Pavel Fedin, 2015/05/07
- Re: [Qemu-devel] [PATCH RFC V2 4/4] Add virtv2 machine that uses GIC-500, Shlomo Pongratz, 2015/05/07
Re: [Qemu-devel] [PATCH RFC V2 4/4] Add virtv2 machine that uses GIC-500, Eric Auger, 2015/05/19