[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 04/20] monitor: Convert client_migrate_info to Q
From: |
Daniel P. Berrange |
Subject: |
Re: [Qemu-devel] [PATCH 04/20] monitor: Convert client_migrate_info to QAPI |
Date: |
Tue, 26 May 2015 13:52:41 +0100 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Tue, May 26, 2015 at 02:51:45PM +0200, Gerd Hoffmann wrote:
> Hi,
>
> > >> +#
> > >> +# Set the spice/vnc connection info for the migration target. The
> > >> +# spice/vnc server will ask the spice/vnc client to automatically
> > >> +# reconnect using the new parameters (if specified) once the vm
> > >> +# migration finished successfully. Not yet implemented for VNC.
> > >> +#
> > >> +# @protocol: must be "spice"
> > >> +# @hostname: migration target hostname
> > >> +# @port: #optional spice/vnc tcp port for plaintext channels
> > >
> > > Is it worth documenting vnc, when we just stated earlier that protocol
> > > must be spice?
> >
> > I think this is a question for Gerd (cc'ed).
>
> IIRC Daniel (added to Cc:) had plans to create a vnc extension for that.
>
> Which was the reason to explicitly add the protocol here, so we can use
> the same command for both spice and vnc some day.
Yeah, it would be nice to do a VNC extension, though realistically I'm
not going to have time for that anytime in the forseeable future.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
- Re: [Qemu-devel] [PATCH 08/20] monitor: Drop unused "new" HMP command interface, (continued)
- [Qemu-devel] [PATCH 10/20] monitor: Propagate errors through qmp_check_input_obj(), Markus Armbruster, 2015/05/22
- [Qemu-devel] [PATCH 12/20] monitor: Inline monitor_has_error() into its only caller, Markus Armbruster, 2015/05/22
- [Qemu-devel] [PATCH 04/20] monitor: Convert client_migrate_info to QAPI, Markus Armbruster, 2015/05/22
- Re: [Qemu-devel] [PATCH 04/20] monitor: Convert client_migrate_info to QAPI, Eric Blake, 2015/05/22
- Re: [Qemu-devel] [PATCH 04/20] monitor: Convert client_migrate_info to QAPI, Markus Armbruster, 2015/05/26
- Re: [Qemu-devel] [PATCH 04/20] monitor: Convert client_migrate_info to QAPI, Gerd Hoffmann, 2015/05/26
- Re: [Qemu-devel] [PATCH 04/20] monitor: Convert client_migrate_info to QAPI,
Daniel P. Berrange <=
- Re: [Qemu-devel] [PATCH 04/20] monitor: Convert client_migrate_info to QAPI, Markus Armbruster, 2015/05/26
- Re: [Qemu-devel] [PATCH 04/20] monitor: Convert client_migrate_info to QAPI, Gerd Hoffmann, 2015/05/26
- Re: [Qemu-devel] [PATCH 04/20] monitor: Convert client_migrate_info to QAPI, Markus Armbruster, 2015/05/26
[Qemu-devel] [PATCH 02/20] monitor: Clean up after previous commit, Markus Armbruster, 2015/05/22
[Qemu-devel] [PATCH 17/20] monitor: Drop do_qmp_capabilities()'s superfluous QMP check, Markus Armbruster, 2015/05/22
[Qemu-devel] [PATCH 06/20] monitor: Use traditional command interface for HMP device_add, Markus Armbruster, 2015/05/22