[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH] net: Enable vlans and dump for -netdev, too
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [RFC PATCH] net: Enable vlans and dump for -netdev, too, |
Date: |
Tue, 26 May 2015 16:29:51 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
Stefan Hajnoczi <address@hidden> writes:
> On Fri, May 22, 2015 at 09:22:19PM +0200, Thomas Huth wrote:
>> So far, it is not possible to use the network dump interface
>> with the "-netdev" option yet, it only works with the legacy
>> "-net" option. To be able to use it with "-netdev", too, this
>> patch now enables the "vlan" packet distribution for the
>> "-netdev" option, too, so that you can now dump network packets
>> like this:
>>
>> qemu... -device e1000,netdev=myhub -netdev hubport,hubid=1,id=myhub \
>> -netdev user,id=n1,vlan=1,tftp=/tmp/tftp,bootfile=zImage \
>> -netdev dump,id=n2,vlan=1,file=/tmp/dump.dat
>>
>> Signed-off-by: Thomas Huth <address@hidden>
>> ---
>> net/net.c | 3 +++
>> qapi-schema.json | 1 +
>> 2 files changed, 4 insertions(+)
>>
>> [Note: I'm quite new to this area of the code, please review carefully
>> whether this approach makes sense or whether it should be done differently]
>
> We thought the QEMU "vlan" concept would be dropped completely in the
> future, so it was never added to -netdev. No patches to do that have
> been posted over the years, so I think it was more of a conceptual goal
> than a concrete requirement.
Well, patches to do that first need to replace the VLAN-only dump
feature.
To fully deprecate -net, we also have to replace -net nic for
configuring onboard NICs.
Prior discussion:
http://lists.nongnu.org/archive/html/qemu-devel/2013-02/msg03743.html
We haven't really tried either.
Thomas's patch declares defeat on VLANs: it ports them to -netdev,
perpetuating the concept.
> I'm okay with merging this but will leave some time for discussion
> before merging the patch.
>
> "Speak now or forever hold your peace"
Sure we're ready to give up without having tried?
- [Qemu-devel] [RFC PATCH] net: Enable vlans and dump for -netdev, too,, Thomas Huth, 2015/05/22
- Re: [Qemu-devel] [RFC PATCH] net: Enable vlans and dump for -netdev, too,, Eric Blake, 2015/05/22
- Re: [Qemu-devel] [RFC PATCH] net: Enable vlans and dump for -netdev, too,, Stefan Hajnoczi, 2015/05/26
- Re: [Qemu-devel] [RFC PATCH] net: Enable vlans and dump for -netdev, too,, Thomas Huth, 2015/05/26
- Re: [Qemu-devel] [RFC PATCH] net: Enable vlans and dump for -netdev, too,,
Markus Armbruster <=
- Re: [Qemu-devel] [RFC PATCH] net: Enable vlans and dump for -netdev, too,, Daniel P. Berrange, 2015/05/26
- Re: [Qemu-devel] [RFC PATCH] net: Enable vlans and dump for -netdev, too,, Stefan Hajnoczi, 2015/05/26
- Re: [Qemu-devel] [RFC PATCH] net: Enable vlans and dump for -netdev, too,, Thomas Huth, 2015/05/26
- Re: [Qemu-devel] [RFC PATCH] net: Enable vlans and dump for -netdev, too,, Markus Armbruster, 2015/05/27